Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in mobile platform when use vim or tmux #65

Open
linhanyu opened this issue Sep 18, 2021 · 1 comment
Open

Crash in mobile platform when use vim or tmux #65

linhanyu opened this issue Sep 18, 2021 · 1 comment
Assignees
@xtyxtyx

Comments

@linhanyu
Copy link
Contributor

image

frontend/terminal_view.dart

this api would trigger reflow and finally run into setScrollOffsetFromBottom, which refresh and make rebuild again. [rebuild in rebuild progress] is not allow so it cause crash in flutter. which happened in vim or tmux application.

image

I think it should be carefully use rebuild api in builder: )
@linhanyu
Copy link
Contributor Author

I have test in my android device, flutter 2.6.

@xtyxtyx xtyxtyx self-assigned this Sep 21, 2021
@linhanyu linhanyu mentioned this issue Sep 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xtyxtyx xtyxtyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xtyxtyx @linhanyu