Skip to content

Commit c021efe

Browse files
kevingpqi123domchen
authored andcommitted
Remove useless code
1 parent 9d3bb92 commit c021efe

File tree

8 files changed

+2
-23
lines changed

8 files changed

+2
-23
lines changed

Diff for: mac/PAGViewer.xcodeproj/project.pbxproj

+2
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,7 @@
574574
CODE_SIGN_IDENTITY = "-";
575575
CODE_SIGN_STYLE = Automatic;
576576
COMBINE_HIDPI_IMAGES = YES;
577+
EXCLUDED_ARCHS = arm64;
577578
INFOPLIST_FILE = PAGViewer/Info.plist;
578579
LD_RUNPATH_SEARCH_PATHS = (
579580
"$(inherited)",
@@ -595,6 +596,7 @@
595596
CODE_SIGN_IDENTITY = "-";
596597
CODE_SIGN_STYLE = Automatic;
597598
COMBINE_HIDPI_IMAGES = YES;
599+
EXCLUDED_ARCHS = arm64;
598600
INFOPLIST_FILE = PAGViewer/Info.plist;
599601
LD_RUNPATH_SEARCH_PATHS = (
600602
"$(inherited)",

Diff for: src/platform/Platform.cpp

-3
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ bool Platform::registerFallbackFonts() const {
7373
return false;
7474
}
7575

76-
void Platform::reportStatisticalData(std::unordered_map<std::string, std::string>&) const {
77-
}
78-
7976
NALUType Platform::naluType() const {
8077
return NALUType::AnnexB;
8178
}

Diff for: src/platform/Platform.h

-5
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,6 @@ class Platform {
107107
*/
108108
virtual bool registerFallbackFonts() const;
109109

110-
/**
111-
* Reports the statistical data of pag.
112-
*/
113-
virtual void reportStatisticalData(std::unordered_map<std::string, std::string>& reportMap) const;
114-
115110
/**
116111
* Returns the default NALU start code type of the current platform.
117112
*/

Diff for: src/platform/android/NativePlatform.cpp

-4
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,6 @@ bool NativePlatform::registerFallbackFonts() const {
9797
return FontConfigAndroid::RegisterFallbackFonts();
9898
}
9999

100-
void NativePlatform::reportStatisticalData(
101-
std::unordered_map<std::string, std::string>&) const {
102-
}
103-
104100
void NativePlatform::traceImage(const pag::PixelMap& pixelMap, const std::string& tag) const {
105101
JTraceImage::Trace(pixelMap, tag);
106102
}

Diff for: src/platform/android/NativePlatform.h

-3
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ class NativePlatform : public Platform {
4949

5050
bool registerFallbackFonts() const override;
5151

52-
void reportStatisticalData(
53-
std::unordered_map<std::string, std::string>& reportMap) const override;
54-
5552
void traceImage(const PixelMap& pixelMap, const std::string& tag) const override;
5653
};
5754
} // namespace pag

Diff for: src/platform/ios/private/NativePlatform.h

-3
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,5 @@ namespace pag {
2424
class NativePlatform : public CocoaPlatform {
2525
public:
2626
std::unique_ptr<VideoDecoder> makeHardwareDecoder(const VideoConfig& config) const override;
27-
28-
void reportStatisticalData(
29-
std::unordered_map<std::string, std::string>& reportMap) const override;
3027
};
3128
} // namespace pag

Diff for: src/platform/ios/private/NativePlatform.mm

-3
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,4 @@
4040
#endif
4141
}
4242

43-
void NativePlatform::reportStatisticalData(
44-
std::unordered_map<std::string, std::string>&) const {
45-
}
4643
}

Diff for: src/rendering/FileReporter.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
/////////////////////////////////////////////////////////////////////////////////////////////////
1818

1919
#include "FileReporter.h"
20-
#include "platform/Platform.h"
2120
#include "rendering/caches/RenderCache.h"
2221
#include "rendering/layers/PAGStage.h"
2322

@@ -104,7 +103,6 @@ void FileReporter::reportData() {
104103
reportInfos.insert(std::make_pair("event", "pag_monitor"));
105104
reportInfos.insert(std::make_pair("version", PAG::SDKVersion()));
106105
reportInfos.insert(std::make_pair("usability", "1"));
107-
Platform::Current()->reportStatisticalData(reportInfos);
108106
}
109107

110108
static int64_t GetOldRenderTime(RenderCache* cache) {

0 commit comments

Comments
 (0)