Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Revise and simplify React Part 1 Lesson #1309

Closed
vegetabill opened this issue Mar 24, 2020 · 10 comments · Fixed by #1310
Closed

[React] Revise and simplify React Part 1 Lesson #1309

vegetabill opened this issue Mar 24, 2020 · 10 comments · Fixed by #1310
Assignees
Labels
MEDIUM Intermediate length or difficulty

Comments

@vegetabill
Copy link
Collaborator

vegetabill commented Mar 24, 2020

This is a child issue of Epic #1301

The current React lesson is not as clear and useful as it could be, and relies too much on external materials.

Content to Add

  • Inline code snippet examples of a Hello World component
  • Inline code snippet of a component with a single prop
  • Inline code snippet of a component assigning a className

Content to Replace/Improve

  • All components should be class-based, not functional
  • Rewrite motivation in your own words. Sum it up as succinctly as possible: what React does and why is it useful. You can also mention it's popular (link to some data on popularity).
  • Replace the existing Guided Practice
    • Use the List CodePen and remove state from it and just walk them through rendering a list using map
    • Use ES6 arrow functions etc
    • Use semantic HTML, like <ol>
    • Discuss and link to the need for key property to prevent warnings
  • Independent practice should not use create-react-app - that is overkill
    • Use one of the CodePen links in "Lesson Materials" and add some required and optional requirements for them to implement
  • Topics to Learn
    • React let's you generate HTML using JavaScript
    • The HTML can change over time, unlike regular HTML
    • No jQuery needed

Content to Remove

  • Objective: "Hook up user actions to state changes in the UI."
  • Any reference to state, this includes the examples like the CodePen Counter and List
  • Wrap Up
  • ES6 link in supplemental features
  • Remove existing prereqs, replace with HTML and JavaScript 6 - OOP or above
  • Common Mistakes No. 1, No.3, No. 4, No. 7
@vegetabill vegetabill added MEDIUM Intermediate length or difficulty gssoc20 labels Mar 24, 2020
@vegetabill vegetabill added this to the H2-2020 Start (June) milestone Mar 24, 2020
@jamesjose03
Copy link
Contributor

@vegetabill I would like to take up this issue.

@Kundan28
Copy link
Collaborator

@vegetabill I would like to take up this issue.

Once your PR is merged, you will be assigned to this.

@prangya244
Copy link
Contributor

I would like to take up this issue.

@Kundan28
Copy link
Collaborator

I would like to take up this issue.

You are already assigned with other issue.

@kichloo
Copy link
Contributor

kichloo commented Mar 29, 2020

@Kundan28 I have submitted my PR and its in the final phase of the review. Pl assign it to me.

@Kundan28
Copy link
Collaborator

@Kundan28 I have submitted my PR and its in the final phase of the review. Pl assign it to me.

Wait for it until it's approved by Alina.

@jamesjose03
Copy link
Contributor

@Kundan28 Pls assign this issue to me as I have already started working on it.

@Kundan28
Copy link
Collaborator

@Kundan28 Pls assign this issue to me as I have already started working on it.

But you were not assigned to this issue.

@kichloo
Copy link
Contributor

kichloo commented Mar 29, 2020

@Kundan28 Now that my PR has been merged, pl.assign it to me.

@Kundan28
Copy link
Collaborator

@Kundan28 Now that my PR has been merged, pl.assign it to me.

Sorry to say but @jamesjose03 would get assigned to this issue as he asked first.
Comment down on other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEDIUM Intermediate length or difficulty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants