Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise integration testing to focus on supertest API testing #1216

Closed
vegetabill opened this issue Feb 28, 2020 · 10 comments
Closed

Revise integration testing to focus on supertest API testing #1216

vegetabill opened this issue Feb 28, 2020 · 10 comments
Labels
MEDIUM Intermediate length or difficulty pinned priority get this done first if possible subject-matter-expert These issues need someone with a little background knowledge to work on them

Comments

@vegetabill
Copy link
Collaborator

vegetabill commented Feb 28, 2020

/testing-and-tdd/integration-testing.md is quite a comprehensive lesson that is underestimated at 2 hours to go through. Also includes too much theory and too much long blocks. It is not skimmable.

Revise Motivation Section

Too long, please revise to be more concrete: "Helps insure your API's won;'t change in a way that breaks your browser app"

Drop mocking

Issue #1217 already created a mocking lesson

Remove postman section

We have no plans to use postman as an API testing framework as it's better for the participants to learn how to write automated API tests.

Promote the API tests using supertests example the primary focus

Integration testing in the context of web apps is usually synonymous with API testing.

Move the "Interlude: Testing APIs with supertest" section to be the main content of this lesson. Revise all the other bullet points sections to match. This may in effect mean mostly rewriting this entire lesson, but try to reuse what you like in the existing content.

For FAQs on how to contribute, see: https://github.com/Techtonica/curriculum/blob/main/CONTRIBUTING.md

@vegetabill vegetabill added the MEDIUM Intermediate length or difficulty label Feb 28, 2020
@vegetabill vegetabill added this to the H2-2020 Start (June) milestone Feb 28, 2020
@vegetabill vegetabill added HARD Large or complex task subject-matter-expert These issues need someone with a little background knowledge to work on them and removed MEDIUM Intermediate length or difficulty gssoc-candidate labels Feb 28, 2020
@vegetabill
Copy link
Collaborator Author

Related to #1215

@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 6, 2020
@stale stale bot closed this as completed May 13, 2020
@alodahl
Copy link
Collaborator

alodahl commented May 20, 2020

I don't know if I agree with this bot. As this isn't a typical industry backlog, neglected doesn't equal worthless. If we don't need it anymore, we should close it intentionally.

@alodahl alodahl reopened this May 20, 2020
@stale stale bot removed the wontfix label May 20, 2020
@vegetabill vegetabill self-assigned this Jun 24, 2020
@vegetabill
Copy link
Collaborator Author

I'll review and split this one up.

@vegetabill
Copy link
Collaborator Author

Seems related to #1215

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 8, 2020
@alodahl alodahl removed the wontfix label Aug 9, 2020
@alodahl alodahl added the pinned label Aug 9, 2020
@alodahl
Copy link
Collaborator

alodahl commented Dec 7, 2020

@vegetabill I see you marked this one as "Before program begins". How do you feel about it? Should we open this to volunteers?

@alodahl alodahl added priority get this done first if possible and removed hackathon labels Dec 7, 2020
@vegetabill
Copy link
Collaborator Author

I think I missed that when prioritizing. The current schedule has this occurring at the end of week 7: https://github.com/Techtonica/curriculum#week-7---databases

So I'll move it to the correct milestone.

@alodahl
Copy link
Collaborator

alodahl commented Dec 30, 2020

Just to double-check, this work makes #961 unnecessary, right? If so, can you please close it?

@vegetabill vegetabill removed their assignment Dec 31, 2020
@vegetabill vegetabill added MEDIUM Intermediate length or difficulty and removed HARD Large or complex task labels Dec 31, 2020
@vegetabill vegetabill changed the title Split the integration testing lesson into multiple parts Revise integration testing to focus on supertest API testing Dec 31, 2020
@alodahl
Copy link
Collaborator

alodahl commented Aug 27, 2021

will not use file as-is now that we've moved to Jest testing.

@alodahl alodahl closed this as completed Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEDIUM Intermediate length or difficulty pinned priority get this done first if possible subject-matter-expert These issues need someone with a little background knowledge to work on them
Projects
None yet
Development

No branches or pull requests

2 participants