Merge pull request #27 from TechnologyEnhancedLearning/TD-2217-accessibility-fix

TD-2217 accessibility fix for radio field-set and date input

Author: OluwatobiAwe

NHSUKViewComponents.Web/Views/Shared/Components/DateInput/Default.cshtml

@@ -25,7 +25,7 @@
 
     @if (Model.HintTextLines != null) {
       @foreach (var hintText in Model.HintTextLines) {
-        <div class="nhsuk-hint">
+        <div class="nhsuk-hint" id="@Model.Id-hint">
           @hintText
         </div>
       }

NHSUKViewComponents.Web/Views/Shared/Components/ErrorSummary/Default.cshtml

@@ -11,9 +11,12 @@
             <ul class="nhsuk-list nhsuk-error-summary__list">
                 @foreach (var item in Model.Errors.OrderBy(x => x.Key))
                 {
-                    <li>
-                        <a href="#@item.Key">@item.ErrorMessage</a>
-                    </li>
+                    if (!string.IsNullOrWhiteSpace(item.ErrorMessage))
+                    {
+                        <li>
+                            <a href="#@item.Key">@item.ErrorMessage</a>
+                        </li>
+                    }  
                 }
             </ul>
         </div>

NHSUKViewComponents.Web/Views/Shared/Components/RadioList/Default.cshtml

@@ -9,7 +9,7 @@
 
 <div class="nhsuk-form-group @(Model.HasError ? "nhsuk-form-group--error" : "")">
 
-    <fieldset class="nhsuk-fieldset" aria-describedby="@Model.Label.RemoveWhitespace()-hint">
+    <fieldset class="nhsuk-fieldset" aria-describedby="@(!string.IsNullOrEmpty(Model.HintText) ? $"{Model.Label.RemoveWhitespace()}-hint" : string.Empty)">
         <legend class="nhsuk-fieldset__legend nhsuk-fieldset__legend--m">
             @if (Model.IsPageHeading.GetValueOrDefault() == true)
             {