You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was looking through the source for the launcher and found that when File::equals(File) is called, it just does a comparison on the Paths from the Files which is implemented as file1.getPath().compareToIgnoreCase(file2.getPath()). Anywhere else in the launcher code that compares Paths without first converting to canonical is subject to the issue as well.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I was looking through the source for the launcher and found that when
File::equals(File)
is called, it just does a comparison on the Paths from the Files which is implemented asfile1.getPath().compareToIgnoreCase(file2.getPath())
. Anywhere else in the launcher code that compares Paths without first converting to canonical is subject to the issue as well.For example, comparing
/foo/bar/
and/foo/../foo/bar/
would currently give a false-negative when checked for equality in the above two styles, potentially resulting in data loss such as here:https://github.com/TechnicPack/LauncherV3/blob/master/src/main/java/net/technicpack/autoupdate/tasks/MoveLauncherPackage.java#L63
The text was updated successfully, but these errors were encountered: