-
Notifications
You must be signed in to change notification settings - Fork 2k
Adding support for Scruffy with Benchmarks 1, 2 and 6 #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll get right on it. On 21 July 2014 16:45, Alexander Schneider [email protected] wrote:
|
scruffy/benchmark_config
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convention is for this to be lower-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scruffy won't actually say anything once its started (log wise) as I
disabled all logging. I could add something back in to say "server running"
or something, which when you think about it was stupid of me to take out.
On 21 July 2014 16:47, Alexander Schneider [email protected] wrote:
In scruffy/benchmark_config:
@@ -0,0 +1,26 @@
+{
- "framework": "Scruffy",
Convention is for this to be lower-case.
—
Reply to this email directly or view it on GitHub
https://github.com/TechEmpower/FrameworkBenchmarks/pull/867/files#r15176418
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an explicit "scruffy is running" line to the console. You should
see something like this when running.
sam@sam-ubuntu:~/development/workspace/FrameworkBenchmarks/scruffy$ java
-jar target/scala-2.11/scruffy-benchmark-assembly-1.0.1.jar
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
Starting Scruffy...
Started on port [8080]. Interrupt to exit.
The other points have been addressed.
On 21 July 2014 16:50, Stephen Samuel (Sam) [email protected] wrote:
Scruffy won't actually say anything once its started (log wise) as I
disabled all logging. I could add something back in to say "server running"
or something, which when you think about it was stupid of me to take out.On 21 July 2014 16:47, Alexander Schneider [email protected]
wrote:In scruffy/benchmark_config:
@@ -0,0 +1,26 @@
+{
- "framework": "Scruffy",
Convention is for this to be lower-case.
—
Reply to this email directly or view it on GitHub
https://github.com/TechEmpower/FrameworkBenchmarks/pull/867/files#r15176418
.
|
Hello @sksamuel , The test should be working fine, some notes: The json response needs to be "Hello, World!" exactly, with the comma and exclamation mark. The db for the single query test needs to be "hello_world", either "world" or "World" as a collection is fine. It seems that the single query test is casting the _id field and the randomNumber field as floating point numbers instead of integers, could you please correct this, such that the output consists of integers only? Plaintext passes. Regards, James |
…utput ints not floats.
|
Those should good now thanks! |
No description provided.