-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce/eliminate our Node use #188
Comments
Once we've done this, I think we can also remove the Edit: Removed this gem as part of #189 for reasons explained in its description. |
I'm not going to rush this because there are more important things to do (although this is important to tackle soon so that our codebase has a very clear MO), but I did just do a quick test of the following changes, and it all worked just fine:
After doing that, the app still ran and worked just fine. What I suspect we'd also have to do to close the loop:
|
Well, apologies for the whiplash, but I no longer thing we should do this, and in fact think we should revert back entirely to a bundled setup. The pragmatic justification is that I think we should use Flowbite, and we simply can't use Flowbite correctly with importmaps. Full stop. DHH says as much here.
The philosophical justification uses the pragmatic one as a case study in how complicated and limiting it (currently) is to live without the normal expected access to the npm ecosystem; we can use a lot of it, but with exceptions and customizations and contortions that complicate life. If we were only writing our own JS, or knew we'd only be using individual/atomic JS libraries, then importmaps would be great. And I hope we can convert back at some point! But for now, I think it's too early / not advantageous enough. |
After some Slack chatter with @cguess, it's… possible that we don't actually need Node/yarn on this project at all.
This issue is for discussing (if necessary) any consequences, tracking any complications, and then actually doing it.
Among the unknowns:
vendor/
dir); but maybe those are dangerous anti-patterns anyway?The text was updated successfully, but these errors were encountered: