Skip to content

Changes for "Show Replies" #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
golfinq wants to merge 3 commits into from
Closed

Changes for "Show Replies" #739

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46b823c
Changes for "Show Replies"
golfinq Oct 13, 2021
b211af5
Fixed Behavior when scrolling
golfinq Oct 15, 2021
c89cc71
Moved Downloading to NewPipe
golfinq Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfoItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class CommentsInfoItem extends InfoItem {
private int streamPosition;
@Nullable
private Page replies;
private boolean repliesOpen = false;

public static final int NO_LIKE_COUNT = -1;
public static final int NO_STREAM_POSITION = -1;
Expand Down Expand Up @@ -149,4 +150,10 @@ public int getStreamPosition() {
public void setReplies(@Nullable Page replies) { this.replies = replies; }

public Page getReplies() { return this.replies; }

public void setRepliesOpen(boolean repliesOpen) {
this.repliesOpen = repliesOpen;
}

public boolean getRepliesOpen() {return this.repliesOpen; }
Comment on lines +153 to +158
Copy link
Member

@Stypox Stypox Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be done in the Extractor code, since this is just a UI thing

}