Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu "Open in Terminal" option #4213

Open
wants to merge 1 commit into
base: release/4.0
Choose a base branch
from

Conversation

TranceLove
Copy link
Collaborator

@TranceLove TranceLove commented Jul 6, 2024

Description

Adds option to open specified folder in terminal app.

Supports TermOne Plus, Termux. Jack Palovich's Android Terminal is also supported in code, but not thoroughly tested since it's no longer in development.

Expected user to do all the configuration at Terminal app's own side - like this, the most Amaze can do is check for corresponding app permission and prompt user to grant.

Issue tracker

Fixes #2666

Automatic tests

  • Added test cases

Manual tests

  • Done

  • Device: Nexus 4 emulator

  • OS: Android 8

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove
Copy link
Collaborator Author

TranceLove commented Jul 6, 2024

Pending tasks:

  • Fix codacy complaints

@TranceLove TranceLove marked this pull request as ready for review July 6, 2024 10:05
@VishalNehra
Copy link
Member

Pressing on the option 'open in terminal' does nothing on me device
I just have below logs that was showing error level not sure how helpful it would be

2024-07-18 02:45:05.277 3045-3951 UAH_JNI pid-3045 E uah_rule_ctrl id = 0x1 ,value = pkgName:com.amaze.filemanager.debug,type:1,activityName:com.amaze.filemanager.debug/com.amaze.filemanager.ui.activities.MainActivity,isFocused:true|pkgName:com.android.launcher,type:1,activityName:com.android.launcher/.Launcher,isFocused:false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Open in Terminal" button
2 participants