moved button to switch instance (and to portable mode) to the main window

Author: TanninOne

src/instancemanager.cpp

@@ -27,6 +27,7 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include <QStandardPaths>
 #include <QInputDialog>
 #include <QMessageBox>
+#include <cstdint>
 
 
 static const char COMPANY_NAME[]     = "Tannin";
@@ -40,6 +41,11 @@ InstanceManager::InstanceManager()
 {
 }
 
+InstanceManager &InstanceManager::instance()
+{
+  static InstanceManager s_Instance;
+  return s_Instance;
+}
 
 QString InstanceManager::currentInstance() const
 {
@@ -49,6 +55,7 @@ QString InstanceManager::currentInstance() const
 void InstanceManager::clearCurrentInstance()
 {
   setCurrentInstance("");
+  m_Reset = true;
 }
 
 void InstanceManager::setCurrentInstance(const QString &name)
@@ -81,26 +88,51 @@ QString InstanceManager::queryInstanceName() const
 
 QString InstanceManager::chooseInstance(const QStringList &instanceList) const
 {
-  SelectionDialog selection(QObject::tr("Choose Instance"), nullptr);
+  enum class Special : uint8_t {
+    NewInstance,
+    Portable
+  };
+
+  SelectionDialog selection(
+      QString("<h3>%1</h3><br>%2")
+          .arg(QObject::tr("Choose Instance"))
+          .arg(QObject::tr(
+              "Each Instance is a full set of MO data files (mods, "
+              "downloads, profiles, configuration, ...). Use multiple "
+              "instances for different games. If your MO folder is "
+              "writable, you can also store a single instance locally (called "
+              "a portable install).")),
+      nullptr);
   selection.disableCancel();
   for (const QString &instance : instanceList) {
     selection.addChoice(instance, "", instance);
   }
 
-  selection.addChoice(QObject::tr("New"),
+  selection.addChoice(QIcon(":/MO/gui/add"), QObject::tr("New"),
                       QObject::tr("Create a new instance."),
-                      "");
+                      static_cast<uint8_t>(Special::NewInstance));
+
+  if (QFileInfo(qApp->applicationDirPath()).isWritable()) {
+    selection.addChoice(QIcon(":/MO/gui/package"), QObject::tr("Portable"),
+                        QObject::tr("Use MO folder for data."),
+                        static_cast<uint8_t>(Special::Portable));
+  }
+
   if (selection.exec() == QDialog::Rejected) {
     qDebug("rejected");
     throw MOBase::MyException(QObject::tr("Canceled"));
   }
 
-  QString choice = selection.getChoiceData().toString();
+  QVariant choice = selection.getChoiceData();
 
-  if (choice.isEmpty()) {
-    return queryInstanceName();
+  if (choice.type() == QVariant::String) {
+    return choice.toString();
   } else {
-    return choice;
+    switch (choice.value<uint8_t>()) {
+      case Special::NewInstance: return queryInstanceName();
+      case Special::Portable: return QString();
+      default: throw std::runtime_error("invalid selection");
+    }
   }
 }
 
@@ -125,27 +157,6 @@ bool InstanceManager::portableInstall() const
 }
 
 
-InstanceManager::InstallationMode InstanceManager::queryInstallMode() const
-{
-  SelectionDialog selection(QObject::tr("Installation Mode"), nullptr);
-  selection.disableCancel();
-  selection.addChoice(QObject::tr("Portable"),
-                      QObject::tr("Everything in one directory, only one game per installation."),
-                      0);
-  selection.addChoice(QObject::tr("Regular"),
-                      QObject::tr("Data in separate directory, multiple games supported."),
-                      1);
-  if (selection.exec() == QDialog::Rejected) {
-    throw MOBase::MyException(QObject::tr("Canceled"));
-  }
-
-  switch (selection.getChoiceData().toInt()) {
-    case 0:  return InstallationMode::PORTABLE;
-    default: return InstallationMode::REGULAR;
-  }
-}
-
-
 void InstanceManager::createDataPath(const QString &dataPath) const
 {
   if (!QDir(dataPath).exists()) {
@@ -166,31 +177,22 @@ void InstanceManager::createDataPath(const QString &dataPath) const
 QString InstanceManager::determineDataPath()
 {
   QString instanceId = currentInstance();
+  if (instanceId.isEmpty() && portableInstall() && !m_Reset) {
+    // startup, apparently using portable mode before
+    return qApp->applicationDirPath();
+  }
+
   QString dataPath = QDir::fromNativeSeparators(
         QStandardPaths::writableLocation(QStandardPaths::DataLocation)
         + "/" + instanceId);
 
-  if ((instanceId.isEmpty() || !QFileInfo::exists(dataPath)) && !portableInstall()) {
-    // no portable install and no selected instance
-
-    QStringList instanceList = instances();
-
-    if (instanceList.size() == 0) {
-      if (QFileInfo(qApp->applicationDirPath()).isWritable()) {
-        switch (queryInstallMode()) {
-          case InstallationMode::PORTABLE: {
-            instanceId = QString();
-          } break;
-          case InstallationMode::REGULAR: {
-            instanceId = queryInstanceName();
-          } break;
-        }
-      } else {
-        instanceId = queryInstanceName();
-      }
-    } else {
-      // don't offer portable instance if we can't set one up.
-      instanceId = chooseInstance(instanceList);
+
+  if (instanceId.isEmpty() || !QFileInfo::exists(dataPath)) {
+    instanceId = chooseInstance(instances());
+    if (!instanceId.isEmpty()) {
+      dataPath = QDir::fromNativeSeparators(
+        QStandardPaths::writableLocation(QStandardPaths::DataLocation)
+        + "/" + instanceId);
     }
   }
 

src/instancemanager.h

@@ -27,36 +27,33 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 
 class InstanceManager {
 
-  enum class InstallationMode {
-    PORTABLE,
-    REGULAR
-  };
-
 public:
 
-  InstanceManager();
+  static InstanceManager &instance();
 
   QString determineDataPath();
-  QStringList instances() const;
   void clearCurrentInstance();
 
 private:
 
+  InstanceManager();
+
   QString currentInstance() const;
   QString instancePath() const;
 
-  bool portableInstall() const;
+  QStringList instances() const;
 
   void setCurrentInstance(const QString &name);
 
   QString queryInstanceName() const;
   QString chooseInstance(const QStringList &instanceList) const;
 
   void createDataPath(const QString &dataPath) const;
-  InstallationMode queryInstallMode() const;
+  bool portableInstall() const;
 
 private:
 
   QSettings m_AppSettings;
+  bool m_Reset {false};
 
 };

src/main.cpp

@@ -630,13 +630,12 @@ int main(int argc, char *argv[])
     QString dataPath;
 
     try {
-      dataPath = InstanceManager().determineDataPath();
+      dataPath = InstanceManager::instance().determineDataPath();
     } catch (const std::exception &e) {
       QMessageBox::critical(nullptr, QObject::tr("Failed to set up instance"),
                             e.what());
       return 1;
     }
-
     application.setProperty("dataPath", dataPath);
 
     LogBuffer::init(100, QtDebugMsg, qApp->property("dataPath").toString() + "/logs/mo_interface.log");
@@ -647,7 +646,6 @@ int main(int argc, char *argv[])
     }
 
     int result = runApplication(application, instance, splash);
-
     if (result != INT_MAX) {
       return result;
     }

src/mainwindow.cpp

@@ -37,6 +37,7 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include "savegameinfo.h"
 #include "spawn.h"
 #include "versioninfo.h"
+#include "instancemanager.h"
 
 #include "report.h"
 #include "modlist.h"
@@ -3883,6 +3884,17 @@ void MainWindow::on_actionProblems_triggered()
   }
 }
 
+void MainWindow::on_actionChange_Game_triggered()
+{
+  if (QMessageBox::question(this, tr("Are you sure?"),
+                            tr("This will restart MO, continue?"),
+                            QMessageBox::Yes | QMessageBox::Cancel)
+      == QMessageBox::Yes) {
+    InstanceManager::instance().clearCurrentInstance();
+    qApp->exit(INT_MAX);
+  }
+}
+
 void MainWindow::setCategoryListVisible(bool visible)
 {
   if (visible) {

src/mainwindow.h

@@ -183,6 +183,9 @@ public slots:
   virtual void dragEnterEvent(QDragEnterEvent *event);
   virtual void dropEvent(QDropEvent *event);
 
+private slots:
+  void on_actionChange_Game_triggered();
+
 private slots:
   void on_clickBlankButton_clicked();
 

src/mainwindow.ui

@@ -1197,6 +1197,7 @@ p, li { white-space: pre-wrap; }
    <attribute name="toolBarBreak">
     <bool>false</bool>
    </attribute>
+   <addaction name="actionChange_Game"/>
    <addaction name="actionInstallMod"/>
    <addaction name="actionNexus"/>
    <addaction name="actionAdd_Profile"/>
@@ -1383,6 +1384,18 @@ Right now this has very limited functionality</string>
     <string>Ctrl+C</string>
    </property>
   </action>
+  <action name="actionChange_Game">
+   <property name="icon">
+    <iconset resource="resources.qrc">
+     <normaloff>:/MO/gui/app_icon</normaloff>:/MO/gui/app_icon</iconset>
+   </property>
+   <property name="text">
+    <string>Change Game</string>
+   </property>
+   <property name="toolTip">
+    <string>Open the game selection dialog</string>
+   </property>
+  </action>
  </widget>
  <layoutdefault spacing="6" margin="11"/>
  <customwidgets>

src/nxmaccessmanager.cpp

@@ -215,7 +215,6 @@ void NXMAccessManager::login(const QString &username, const QString &password)
     emit loginSuccessful(false);
     return;
   }
-
   m_Username = username;
   m_Password = password;
   pageLogin();
@@ -237,7 +236,6 @@ QString NXMAccessManager::userAgent(const QString &subModule) const
 void NXMAccessManager::pageLogin()
 {
   qDebug("logging %s in on Nexus", qPrintable(m_Username));
-
   QString requestString = (Nexus_Management_URL + "/Sessions/?Login&uri=%1")
                             .arg(QString(QUrl::toPercentEncoding(Nexus_Management_URL)));
 

src/resources.qrc

@@ -26,7 +26,6 @@
         <file alias="update_available">resources/software-update-available.png</file>
         <file alias="important">resources/emblem-important.png</file>
         <file alias="check">resources/check.png</file>
-        <file>mo_icon.ico</file>
         <file alias="warning">resources/dialog-warning.png</file>
         <file alias="emblem_backup">resources/symbol-backup.png</file>
         <file alias="icon_tools">resources/applications-accessories.png</file>
@@ -68,6 +67,8 @@
         <file alias="active">resources/status_active.png</file>
         <file alias="awaiting">resources/status_awaiting.png</file>
         <file alias="inactive">resources/status_inactive.png</file>
+        <file alias="app_icon">resources/mo_icon.png</file>
+        <file alias="package">resources/package.png</file>
     </qresource>
     <qresource prefix="/MO/gui/content">
         <file alias="plugin">resources/contents/jigsaw-piece.png</file>

src/resources/mo_icon.png

@@ -217,18 +217,6 @@ void SettingsDialog::on_associateButton_clicked()
   Settings::instance().registerAsNXMHandler(true);
 }
 
-void SettingsDialog::on_changeInstanceButton_clicked()
-{
-  if (QMessageBox::question(this, tr("Are you sure?"),
-                            tr("This will restart MO, continue?"),
-                            QMessageBox::Yes | QMessageBox::Cancel)
-      == QMessageBox::Yes) {
-    InstanceManager().clearCurrentInstance();
-    this->reject();
-    qApp->exit(INT_MAX);
-  }
-}
-
 void SettingsDialog::on_clearCacheButton_clicked()
 {
   QDir(Settings::instance().getCacheDirectory()).removeRecursively();

src/resources/package.png

@@ -52,21 +52,6 @@ public slots:
 
   void resetDialogs();
 
-private slots:
-  void on_clearCacheButton_clicked();
-
-private slots:
-  void on_browseBaseDirBtn_clicked();
-
-private slots:
-  void on_browseOverwriteDirBtn_clicked();
-
-private slots:
-  void on_browseProfilesDirBtn_clicked();
-
-private slots:
-  void on_changeInstanceButton_clicked();
-
 private:
 
   void storeSettings(QListWidgetItem *pluginItem);
@@ -92,6 +77,14 @@ private slots:
 
   void on_associateButton_clicked();
 
+  void on_clearCacheButton_clicked();
+
+  void on_browseBaseDirBtn_clicked();
+
+  void on_browseOverwriteDirBtn_clicked();
+
+  void on_browseProfilesDirBtn_clicked();
+
 private:
     Ui::SettingsDialog *ui;
 };