Special character in URL (ex: ê) with a <Link /> component for the same URL causes a SSR error

[olivier-deschenes]

Which project does this relate to?

Start

Describe the bug

When you reload a route with a param and the param has a special character like ê, the link component in the route component seems to bug when SSR is activated.

I assume that it is because the special character is encoded/decoded at a different time in the server / client (one is encoded and the other not).

Your Example Website or App

https://github.com/olivier-deschenes/tanstack-start-special-char-ssr-bug

Steps to Reproduce the Bug or Issue

1. install the deps and run the app
2. Open the app (it should redirect you to the right url)
3. reload the page
4. Check the console

Expected behavior

Nothing should happens, no error in the console

Screenshots or Videos

Platform

• Start version : ^1.131.26

Additional context

It seems to only happen when their is a special character in the url.

[schiller-manuel]

the issue here is that when the link is rendered on the client, the comparison here fails:

router/packages/react-router/src/link.tsx

Lines 147 to 153 in 3f05c0b

	const currentPathSplit = removeTrailingSlash(
	s.location.pathname,
	router.basepath,
	)
	const nextPathSplit = removeTrailingSlash(
	next.pathname,
	router.basepath,

s.location.pathname has the path in the form of '/test/ê' while next.pathname is '/test/%C3%AA'

[olivier-deschenes]

Right now the fix that I use is to simply decode/encode and normalize the params.

export const Route = createFileRoute("/test/$id")({
  component: RouteComponent,
  params: {
    parse: (raw) => ({ id: decodeURIComponent(raw.id).normalize("NFC") }),
    stringify: (v) => ({ id: encodeURIComponent(v.id.normalize("NFC")) }),
  },
});

But I assume that it is a bug right ?
It happens with spaces also.

[schiller-manuel]

yes it is a bug

[olivier-deschenes]

@schiller-manuel is there any plan to fix this in a future release ?

[schiller-manuel]

absolutely! contributions welcome as well

[nlynzaad]

think this might be resolved with #5663 available from 1.133.35. please can you check and confirm.

[olivier-deschenes]

Hi,

It is indeed solved. However, I tried to use the v1.133.32 and it is also solved in this one, so I do not think that this specific version solves it. Maybe the RC.

Nonetheless, thank you !