-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update query function to include page parameter #9792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the first example was broken, now it works!
|
WalkthroughDocumentation update to the React paginated queries guide. The Changes
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~3 minutes Poem
Pre-merge checks and finishing touchesβ Failed checks (1 inconclusive)
β Passed checks (2 passed)
β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
π Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro π Files selected for processing (1)
π Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TkDodo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
βdependsβ on how fetchProjects is implemented, as we inject the queryKey into the queryFn so you have all the information to run it that way. But yes, this is the more common approach
the first example was broken, now it works!
π― Changes
the first example in the pagination docs was broken, now it works!
β Checklist
pnpm run test:pr. (doesn't apply)π Release Impact
Summary by CodeRabbit
Release Notes