Skip to content

Remove fragment in disabling-queries guide code example #9619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

Remove fragment in disabling-queries guide code example #9619

merged 1 commit into from
Sep 5, 2025

Conversation

@ZakKa89
Copy link
Contributor

@ZakKa89 ZakKa89 commented Sep 5, 2025 •
edited by coderabbitai bot
Loading

Fragment is not needed here

Summary by CodeRabbit

  • Documentation
    • Updated the React guide (disabling queries) with a cleaner Todos example. Simplified the markup by removing an unnecessary wrapper to improve readability and copy-paste usability. No behavioral changes: data mapping, loading, and error branches remain the same. This makes the example clearer and more aligned with best practices.

@ZakKa89
Remove fragment in disabling-queries guide
471284d 
Fragment is not needed here
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 5, 2025 •
edited
Loading

Walkthrough

A docs snippet in a React guide was updated to remove an unnecessary React Fragment around a list in a Todos example. The example now directly renders a single

    with mapped items. No other branches or public APIs were changed.

    Changes

    Cohort / File(s) Summary
    Docs - React guide cleanup
    docs/framework/react/guides/disabling-queries.md    		 Removed a React Fragment around the <ul> in the data-present branch of the Todos example; mapping logic and keys unchanged.

    Estimated code review effort

    🎯 2 (Simple) | ⏱️ ~8 minutes

    Poem

    I nibbled the Fragment, a crunchy bite,
    Leaving one tidy <ul> in the light.
    No keys disturbed, no logic askew—
    Just cleaner leaves for data to chew.
    Hippity-hop, the docs feel new! 🐇✨

    📜 Recent review details

    Configuration used: CodeRabbit UI

    Review profile: CHILL

    Plan: Pro

    💡 Knowledge Base configuration:

    • MCP integration is disabled by default for public repositories
    • Jira integration is disabled by default for public repositories
    • Linear integration is disabled by default for public repositories

    You can enable these sources in your CodeRabbit configuration.

    📥 Commits

    Reviewing files that changed from the base of the PR and between 2283633 and 471284d.

    📒 Files selected for processing (1)
    • docs/framework/react/guides/disabling-queries.md (1 hunks)
    🔇 Additional comments (1)
    docs/framework/react/guides/disabling-queries.md (1)

    34-38: Unnecessary Fragment removed — cleaner JSX, same behavior.

    Returning a single

      makes the fragment redundant. Mapping and keys remain correct; no semantic change.

    ✨ Finishing Touches
    🧪 Generate unit tests
    • Create PR with unit tests
    • Post copyable unit tests in a comment

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share
    🪧 Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>, please review it.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

    Support

    Need help? Create a ticket on our support page for assistance with any issues or questions.

    CodeRabbit Commands (Invoked using PR/Issue comments)

    Type @coderabbitai help to get the list of available commands.

    Other keywords and placeholders

    • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
    • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
    • Add @coderabbitai anywhere in the PR title to generate the title automatically.

    CodeRabbit Configuration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Status, Documentation and Community

    • Visit our Status Page to check the current availability of CodeRabbit.
    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 5, 2025
@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 471284d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-05 14:44:44 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 5, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9619

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9619

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9619

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9619

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9619

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9619

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9619

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9619

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9619

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9619

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9619

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9619

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9619

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9619

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9619

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9619

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9619

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9619

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9619

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9619

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9619

commit: 471284d

@TkDodo TkDodo merged commit f49cc75 into TanStack:main Sep 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZakKa89 @TkDodo