Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-query): export QueryErrorResetBoundaryFunction #8089

Merged

Conversation

DogPawHat
Copy link
Contributor

@DogPawHat DogPawHat commented Sep 23, 2024

Export the QueryErrorResetBoundaryFunction render prop function signature so users don't have to write wierd types of there own

In response to an issue I saw on Theo's discord where someone had this ugly code:

type ResetFunction = Parameters<Exclude<QueryErrorResetBoundaryProps["children"], React.ReactNode>>[0]["reset"];

So now that could just be replaced with

import { QueryErrorResetBoundary, type QueryErrorResetFunction } from '@tanstack/react-query'

Export the QueryErrorResetBoundaryFunction render prop function
signature so users don't have to write wierd types of there own
@DogPawHat DogPawHat changed the title feat(reaet-query): export QueryErrorResetBoundaryFunction feat(react-query): export QueryErrorResetBoundaryFunction Sep 23, 2024
Copy link

nx-cloud bot commented Sep 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit baf88fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 23, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8089

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8089

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8089

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8089

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8089

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8089

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8089

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8089

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8089

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8089

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8089

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8089

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8089

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8089

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8089

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8089

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8089

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8089

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8089

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8089

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8089

commit: baf88fd

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (2fe16e5) to head (baf88fd).
Report is 28 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8089       +/-   ##
===========================================
+ Coverage   45.41%   81.84%   +36.43%     
===========================================
  Files         200       26      -174     
  Lines        7456      358     -7098     
  Branches     1696       98     -1598     
===========================================
- Hits         3386      293     -3093     
+ Misses       3694       56     -3638     
+ Partials      376        9      -367     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 93.10% <100.00%> (-0.03%) ⬇️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@DogPawHat DogPawHat marked this pull request as ready for review September 23, 2024 15:42
@TkDodo TkDodo merged commit 4dfb0fc into TanStack:main Oct 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants