From 4f20910313dcd0b4895ce841f7ea401883722996 Mon Sep 17 00:00:00 2001 From: ShacharHarshuv Date: Mon, 29 Apr 2024 10:49:14 -0400 Subject: [PATCH 1/3] Fix PR --- .../src/__tests__/query-options.test-d.ts | 19 +++++++++++++++++++ .../src/query-options.ts | 9 +++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/packages/angular-query-experimental/src/__tests__/query-options.test-d.ts b/packages/angular-query-experimental/src/__tests__/query-options.test-d.ts index 4afe19c2af..5ec64e83bb 100644 --- a/packages/angular-query-experimental/src/__tests__/query-options.test-d.ts +++ b/packages/angular-query-experimental/src/__tests__/query-options.test-d.ts @@ -25,6 +25,25 @@ describe('queryOptions', () => { }, }) }) + + test('should allow undefined response in initialData', () => { + return (id: string | null) => + queryOptions({ + queryKey: ['todo', id], + queryFn: () => + Promise.resolve({ + id: '1', + title: 'Do Laundry', + }), + initialData: () => + !id + ? undefined + : { + id, + title: 'Initial Data', + }, + }) + }) }) test('should work when passed to injectQuery', () => { diff --git a/packages/angular-query-experimental/src/query-options.ts b/packages/angular-query-experimental/src/query-options.ts index 6f89bea03a..4bc4233ba2 100644 --- a/packages/angular-query-experimental/src/query-options.ts +++ b/packages/angular-query-experimental/src/query-options.ts @@ -1,4 +1,9 @@ -import type { DataTag, DefaultError, QueryKey } from '@tanstack/query-core' +import type { + DataTag, + DefaultError, + InitialDataFunction, + QueryKey, +} from '@tanstack/query-core' import type { CreateQueryOptions, NonUndefinedGuard } from './types' /** @@ -10,7 +15,7 @@ export type UndefinedInitialDataOptions< TData = TQueryFnData, TQueryKey extends QueryKey = QueryKey, > = CreateQueryOptions & { - initialData?: undefined + initialData?: undefined | InitialDataFunction> } /** From 4cfa6ffb73fd31d3420cb7eef22e11f0677a58af Mon Sep 17 00:00:00 2001 From: ShacharHarshuv Date: Mon, 29 Apr 2024 17:15:39 -0400 Subject: [PATCH 2/3] Fix for react adapter --- .../src/__tests__/queryOptions.test-d.tsx | 19 +++++++++++++++++++ packages/react-query/src/queryOptions.ts | 9 +++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/packages/react-query/src/__tests__/queryOptions.test-d.tsx b/packages/react-query/src/__tests__/queryOptions.test-d.tsx index dcb8d0ca47..232f55a2b0 100644 --- a/packages/react-query/src/__tests__/queryOptions.test-d.tsx +++ b/packages/react-query/src/__tests__/queryOptions.test-d.tsx @@ -169,4 +169,23 @@ describe('queryOptions', () => { const data = queryClient.getQueryData(options.queryKey) expectTypeOf(data).toEqualTypeOf() }) + + it('should allow undefined response in initialData', () => { + return (id: string | null) => + queryOptions({ + queryKey: ['todo', id], + queryFn: () => + Promise.resolve({ + id: '1', + title: 'Do Laundry', + }), + initialData: () => + !id + ? undefined + : { + id, + title: 'Initial Data', + }, + }) + }) }) diff --git a/packages/react-query/src/queryOptions.ts b/packages/react-query/src/queryOptions.ts index 5eae0e4c23..ec1c11aa2c 100644 --- a/packages/react-query/src/queryOptions.ts +++ b/packages/react-query/src/queryOptions.ts @@ -1,4 +1,9 @@ -import type { DataTag, DefaultError, QueryKey } from '@tanstack/query-core' +import type { + DataTag, + DefaultError, + InitialDataFunction, + QueryKey, +} from '@tanstack/query-core' import type { UseQueryOptions } from './types' export type UndefinedInitialDataOptions< @@ -7,7 +12,7 @@ export type UndefinedInitialDataOptions< TData = TQueryFnData, TQueryKey extends QueryKey = QueryKey, > = UseQueryOptions & { - initialData?: undefined + initialData?: undefined | InitialDataFunction> } type NonUndefinedGuard = T extends undefined ? never : T From 80053f10f6d368c5d4b80babc1acf4484df1b017 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Thu, 1 Aug 2024 13:28:14 +0000 Subject: [PATCH 3/3] ci: apply automated fixes --- packages/react-query/src/__tests__/queryOptions.test-d.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-query/src/__tests__/queryOptions.test-d.tsx b/packages/react-query/src/__tests__/queryOptions.test-d.tsx index 4dc700b8fd..03958a63a0 100644 --- a/packages/react-query/src/__tests__/queryOptions.test-d.tsx +++ b/packages/react-query/src/__tests__/queryOptions.test-d.tsx @@ -200,9 +200,9 @@ describe('queryOptions', () => { !id ? undefined : { - id, - title: 'Initial Data', - }, + id, + title: 'Initial Data', + }, }) }) })