feat: Split rollup config for Nx caching (#5487)

lachlancollins · web-flow · commit c5fece748930 · 2023-05-29T16:22:28.000+10:00
diff --git a/nx.json b/nx.json
@@ -8,9 +8,10 @@
           "test:eslint",
           "test:types",
           "test:build",
-          "build:types",
           "build",
-          "rollup"
+          "build:rollup",
+          "build:codemods",
+          "build:types"
         ],
         "accessToken": "ZDdkNDA4MGEtYjNmYi00MWI4LWE1N2QtYTdlNmYxMGJlZWM2fHJlYWQ="
       }
@@ -63,13 +64,12 @@
       "inputs": ["default", "^public"],
       "dependsOn": ["^test:types"]
     },
-    "build:types": {
+    "build": {
       "outputs": [
-        "{projectRoot}/build/**/*.d.ts",
-        "{projectRoot}/build/.tsbuildinfo"
+        "{projectRoot}/build/**/*"
       ],
       "inputs": ["default", "^public"],
-      "dependsOn": ["^build:types"]
+      "dependsOn": ["^build"]
     },
     "test:build": {
       "dependsOn": ["build"],
diff --git a/package.json b/package.json
@@ -14,9 +14,8 @@
     "test:lib:dev": "pnpm --filter \"./packages/**\" run test:lib:dev",
     "test:build": "nx run-many --target=test:build --projects=root",
     "test:types": "nx affected --target=test:types --parallel=5",
-    "build": "nx run-many --target=build --projects=root",
-    "build:types": "nx affected --target=build:types --parallel=5",
-    "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"pnpm run build:types --watch\"",
+    "build": "nx run-many --target=build --projects=root --parallel=5",
+    "watch": "concurrently --kill-others \"pnpm -r build:rollup -w\" \"pnpm -r build:types --watch\"",
     "dev": "pnpm run watch",
     "prettier": "prettier --plugin-search-dir . \"{packages,examples}/**/src/**/*.{md,js,jsx,cjs,ts,tsx,json,vue,svelte}\"",
     "prettier:write": "pnpm run prettier --write",
diff --git a/packages/codemods/tsconfig.eslint.json b/packages/codemods/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs"]
 }
diff --git a/packages/eslint-plugin-query/tsconfig.eslint.json b/packages/eslint-plugin-query/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs"]
 }
diff --git a/packages/query-async-storage-persister/package.json b/packages/query-async-storage-persister/package.json
@@ -33,6 +33,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "dependencies": {
diff --git a/packages/query-async-storage-persister/rollup.config.mjs b/packages/query-async-storage-persister/rollup.config.mjs
@@ -0,0 +1,17 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'query-async-storage-persister',
+    packageDir: '.',
+    jsName: 'QueryAsyncStoragePersister',
+    outputFile: 'index',
+    entryFile: 'src/index.ts',
+    globals: {
+      '@tanstack/query-persist-client-core': 'QueryPersistClientCore',
+    },
+  }),
+])
diff --git a/packages/query-async-storage-persister/tsconfig.eslint.json b/packages/query-async-storage-persister/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/query-broadcast-client-experimental/package.json b/packages/query-broadcast-client-experimental/package.json
@@ -31,6 +31,8 @@
     "clean": "rimraf ./build",
     "test:eslint": "eslint --ext .ts,.tsx ./src",
     "test:types": "tsc",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "dependencies": {
diff --git a/packages/query-broadcast-client-experimental/rollup.config.mjs b/packages/query-broadcast-client-experimental/rollup.config.mjs
@@ -0,0 +1,18 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'query-broadcast-client-experimental',
+    packageDir: '.',
+    jsName: 'QueryBroadcastClient',
+    outputFile: 'index',
+    entryFile: 'src/index.ts',
+    globals: {
+      '@tanstack/query-core': 'QueryCore',
+      'broadcast-channel': 'BroadcastChannel',
+    },
+  }),
+])
diff --git a/packages/query-broadcast-client-experimental/tsconfig.eslint.json b/packages/query-broadcast-client-experimental/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/query-core/package.json b/packages/query-core/package.json
@@ -33,6 +33,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   }
 }
diff --git a/packages/query-core/rollup.config.mjs b/packages/query-core/rollup.config.mjs
@@ -0,0 +1,15 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+    ...buildConfigs({
+      name: 'query-core',
+      packageDir: '.',
+      jsName: 'QueryCore',
+      outputFile: 'index',
+      entryFile: ['src/index.ts'],
+      globals: {},
+    }),
+])
diff --git a/packages/query-core/tsconfig.eslint.json b/packages/query-core/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/query-devtools/package.json b/packages/query-devtools/package.json
@@ -28,6 +28,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "files": [
diff --git a/packages/query-devtools/rollup.config.mjs b/packages/query-devtools/rollup.config.mjs
@@ -0,0 +1,8 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { createTanstackQueryDevtoolsConfig } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  createTanstackQueryDevtoolsConfig(),
+])
diff --git a/packages/query-devtools/tsconfig.eslint.json b/packages/query-devtools/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/query-persist-client-core/package.json b/packages/query-persist-client-core/package.json
@@ -33,6 +33,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "dependencies": {
diff --git a/packages/query-persist-client-core/rollup.config.mjs b/packages/query-persist-client-core/rollup.config.mjs
@@ -0,0 +1,17 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'query-persist-client-core',
+    packageDir: '.',
+    jsName: 'QueryPersistClientCore',
+    outputFile: 'index',
+    entryFile: ['src/index.ts'],
+    globals: {
+      '@tanstack/query-core': 'QueryCore',
+    },
+  }),
+])
diff --git a/packages/query-persist-client-core/tsconfig.eslint.json b/packages/query-persist-client-core/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/query-sync-storage-persister/package.json b/packages/query-sync-storage-persister/package.json
@@ -33,6 +33,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "dependencies": {
diff --git a/packages/query-sync-storage-persister/rollup.config.mjs b/packages/query-sync-storage-persister/rollup.config.mjs
@@ -0,0 +1,17 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'query-sync-storage-persister',
+    packageDir: '.',
+    jsName: 'QuerySyncStoragePersister',
+    outputFile: 'index',
+    entryFile: 'src/index.ts',
+    globals: {
+      '@tanstack/query-persist-client-core': 'QueryPersistClientCore',
+    },
+  }),
+])
diff --git a/packages/query-sync-storage-persister/tsconfig.eslint.json b/packages/query-sync-storage-persister/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json
@@ -43,6 +43,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build && cpy build/lib/index.d.ts build/lib/index.prod.d.ts"
   },
   "devDependencies": {
diff --git a/packages/react-query-devtools/rollup.config.mjs b/packages/react-query-devtools/rollup.config.mjs
@@ -0,0 +1,38 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'react-query-devtools',
+    packageDir: '.',
+    jsName: 'ReactQueryDevtools',
+    outputFile: 'index',
+    entryFile: 'src/index.ts',
+    globals: {
+      react: 'React',
+      'react-dom': 'ReactDOM',
+      '@tanstack/react-query': 'ReactQuery',
+      '@tanstack/query-devtools': 'TanstackQueryDevtools',
+    },
+    bundleUMDGlobals: ['@tanstack/query-devtools'],
+  }),
+  ...buildConfigs({
+    name: 'react-query-devtools-prod',
+    packageDir: '.',
+    jsName: 'ReactQueryDevtools',
+    outputFile: 'index.prod',
+    entryFile: 'src/index.ts',
+    globals: {
+      react: 'React',
+      'react-dom': 'ReactDOM',
+      '@tanstack/react-query': 'ReactQuery',
+      '@tanstack/match-sorter-utils': 'MatchSorterUtils',
+      superjson: 'SuperJson',
+    },
+    forceDevEnv: true,
+    forceBundle: true,
+    skipUmdBuild: true,
+  }),
+])
diff --git a/packages/react-query-devtools/tsconfig.eslint.json b/packages/react-query-devtools/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/react-query-persist-client/package.json b/packages/react-query-persist-client/package.json
@@ -33,6 +33,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "devDependencies": {
diff --git a/packages/react-query-persist-client/rollup.config.mjs b/packages/react-query-persist-client/rollup.config.mjs
@@ -0,0 +1,20 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'react-query-persist-client',
+    packageDir: '.',
+    jsName: 'ReactQueryPersistClient',
+    outputFile: 'index',
+    entryFile: 'src/index.ts',
+    globals: {
+      react: 'React',
+      '@tanstack/query-persist-client-core': 'QueryPersistClientCore',
+      '@tanstack/react-query': 'ReactQuery',
+    },
+    bundleUMDGlobals: ['@tanstack/query-persist-client-core'],
+  }),
+])
diff --git a/packages/react-query-persist-client/tsconfig.eslint.json b/packages/react-query-persist-client/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/react-query/package.json b/packages/react-query/package.json
@@ -28,7 +28,9 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "build": "cpy ../codemods/src/**/* ./build/codemods",
+    "build": "pnpm build:rollup && pnpm build:codemods && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
+    "build:codemods": "cpy ../codemods/src/**/* ./build/codemods",
     "build:types": "tsc --build"
   },
   "files": [
diff --git a/packages/react-query/rollup.config.mjs b/packages/react-query/rollup.config.mjs
@@ -0,0 +1,21 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { buildConfigs } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  ...buildConfigs({
+    name: 'react-query',
+    packageDir: '.',
+    jsName: 'ReactQuery',
+    outputFile: 'index',
+    entryFile: ['src/index.ts'],
+    globals: {
+      react: 'React',
+      'react-dom': 'ReactDOM',
+      '@tanstack/query-core': 'QueryCore',
+      'react-native': 'ReactNative',
+    },
+    bundleUMDGlobals: ['@tanstack/query-core'],
+  }),
+])
diff --git a/packages/react-query/tsconfig.eslint.json b/packages/react-query/tsconfig.eslint.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "noEmit": true
   },
-  "include": ["**/*.ts", "**/*.tsx", "./.eslintrc.cjs"]
+  "include": ["**/*.ts", "**/*.tsx", ".eslintrc.cjs", "rollup.config.mjs"]
 }
diff --git a/packages/solid-query/package.json b/packages/solid-query/package.json
@@ -37,6 +37,8 @@
     "test:types": "tsc",
     "test:lib": "vitest run --coverage",
     "test:lib:dev": "pnpm run test:lib --watch",
+    "build": "pnpm build:rollup && pnpm build:types",
+    "build:rollup": "rollup --config rollup.config.mjs",
     "build:types": "tsc --build"
   },
   "files": [
diff --git a/packages/solid-query/rollup.config.mjs b/packages/solid-query/rollup.config.mjs
@@ -0,0 +1,8 @@
+// @ts-check
+
+import { defineConfig } from 'rollup'
+import { createSolidQueryConfig } from "../../scripts/getRollupConfig.mjs"
+
+export default defineConfig([
+  createSolidQueryConfig(),
+])
diff --git a/packages/solid-query/tsconfig.eslint.json b/packages/solid-query/tsconfig.eslint.json
diff --git a/packages/vue-query/package.json b/packages/vue-query/package.json
diff --git a/packages/vue-query/rollup.config.mjs b/packages/vue-query/rollup.config.mjs
diff --git a/packages/vue-query/tsconfig.eslint.json b/packages/vue-query/tsconfig.eslint.json
diff --git a/project.json b/project.json
diff --git a/scripts/getRollupConfig.mjs b/scripts/getRollupConfig.mjs
diff --git a/scripts/types.d.ts b/scripts/types.d.ts

Original file line number	Diff line number	Diff line change
`@@ -3,5 +3,5 @@`
`3`	`3`	`"compilerOptions": {`
`4`	`4`	`"noEmit": true`
`5`	`5`	`},`
`6`		`- "include": ["*/.ts", "*/.tsx", "./.eslintrc.cjs"]`
	`6`	`+ "include": ["*/.ts", "*/.tsx", ".eslintrc.cjs"]`
`7`	`7`	`}`