From 6feee75ba6ad4df647c7afa49baed6d2f419b006 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Tue, 23 Jul 2024 11:18:56 +1000 Subject: [PATCH] ci: remove test:format from Nx --- .github/workflows/autofix.yml | 6 +++--- .github/workflows/ci.yml | 8 ++++---- .github/workflows/labeler.yml | 2 +- .github/workflows/pr.yml | 14 ++++++-------- nx.json | 4 ---- package.json | 5 ++--- 6 files changed, 16 insertions(+), 23 deletions(-) diff --git a/.github/workflows/autofix.yml b/.github/workflows/autofix.yml index dc82d4c2a1..f44bcff450 100644 --- a/.github/workflows/autofix.yml +++ b/.github/workflows/autofix.yml @@ -18,12 +18,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v4.1.7 - name: Setup Tools - uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517 + uses: tanstack/config/.github/setup@main - name: Fix formatting run: pnpm prettier:write - name: Apply fixes - uses: autofix-ci/action@dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a + uses: autofix-ci/action@ff86a557419858bb967097bfc916833f5647fa8c with: commit-message: 'ci: apply automated fixes' diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 02f696bdb6..41f9886be3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,17 +23,17 @@ permissions: jobs: test-and-publish: name: Test & Publish - if: github.repository == 'TanStack/query' + if: github.repository_owner == 'TanStack' runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v4.1.7 with: fetch-depth: 0 - name: Start Nx Agents run: npx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yaml" - name: Setup Tools - uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517 + uses: tanstack/config/.github/setup@main - name: Run Tests run: pnpm run test:ci --parallel=3 - name: Stop Nx Agents @@ -50,7 +50,7 @@ jobs: NPM_TOKEN: ${{ secrets.NPM_TOKEN }} TAG: ${{ inputs.tag }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@v4.5.0 with: directory: packages env: diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index c28106ae50..a271cb7e68 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -7,6 +7,6 @@ jobs: triage: runs-on: ubuntu-latest steps: - - uses: actions/labeler@v4 + - uses: actions/labeler@v4.3.0 with: repo-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 65bc5d5f2a..d321972b86 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -2,8 +2,6 @@ name: pr on: pull_request: - paths-ignore: - - 'media/**' concurrency: group: ${{ github.workflow }}-${{ github.event.number || github.ref }} @@ -21,15 +19,15 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v4.1.7 with: fetch-depth: 0 - name: Start Nx Agents run: npx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yaml" - name: Setup Tools - uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517 + uses: tanstack/config/.github/setup@main - name: Get base and head commits for `nx affected` - uses: nrwl/nx-set-shas@v4 + uses: nrwl/nx-set-shas@v4.0.6 with: main-branch-name: main - name: Run Checks @@ -38,7 +36,7 @@ jobs: if: ${{ always() }} run: npx nx-cloud stop-all-agents - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4 + uses: codecov/codecov-action@v4.5.0 with: directory: packages env: @@ -48,11 +46,11 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v4.1.7 with: fetch-depth: 0 - name: Setup Tools - uses: tanstack/config/.github/setup@629cd3152485cbe985f5a7e66d370c858132c517 + uses: tanstack/config/.github/setup@main - name: Build Packages run: pnpm run build:all - name: Publish Previews diff --git a/nx.json b/nx.json index afb9c2239a..040dbcf567 100644 --- a/nx.json +++ b/nx.json @@ -23,10 +23,6 @@ ] }, "targetDefaults": { - "test:format": { - "cache": true, - "inputs": ["{workspaceRoot}/**/*"] - }, "test:knip": { "cache": true, "inputs": ["{workspaceRoot}/**/*"] diff --git a/package.json b/package.json index 3a12350e3f..9f78445b64 100644 --- a/package.json +++ b/package.json @@ -11,8 +11,8 @@ "clean": "pnpm --filter \"./packages/**\" run clean", "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...')} else {process.exit(1)}\" || npx -y only-allow pnpm", "test": "pnpm run test:ci", - "test:pr": "nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build", - "test:ci": "nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build", + "test:pr": "nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build", + "test:ci": "nx run-many --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build", "test:eslint": "nx affected --target=test:eslint --exclude=examples/**", "test:format": "pnpm run prettier --check", "test:sherif": "sherif -p \"./integrations/*\" -p \"./examples/*\"", @@ -32,7 +32,6 @@ }, "nx": { "includedScripts": [ - "test:format", "test:sherif", "test:knip" ]