console.warn -> non-production console.error

Author: justjake

packages/query-core/src/__tests__/timeoutManager.test.tsx

@@ -21,8 +21,10 @@ describe('timeoutManager', () => {
     }
   }
 
+  let consoleErrorSpy: ReturnType<typeof vi.spyOn>
+
   beforeEach(() => {
-    vi.spyOn(console, 'warn')
+    consoleErrorSpy = vi.spyOn(console, 'error')
   })
 
   afterEach(() => {
@@ -82,23 +84,23 @@ describe('timeoutManager', () => {
         // 1. switching before making any calls does not warn
         const customProvider = createMockProvider()
         manager.setTimeoutProvider(customProvider)
-        expect(console.warn).not.toHaveBeenCalled()
+        expect(consoleErrorSpy).not.toHaveBeenCalled()
 
         // Make a call. The next switch should warn
         manager.setTimeout(vi.fn(), 100)
 
         // 2. switching after making a call should warn
         const customProvider2 = createMockProvider('custom2')
         manager.setTimeoutProvider(customProvider2)
-        expect(console.warn).toHaveBeenCalledWith(
+        expect(consoleErrorSpy).toHaveBeenCalledWith(
           '[timeoutManager]: Switching to custom2 provider after calls to custom provider might result in unexpected behavior.',
         )
 
         // 3. Switching again with no intermediate calls should not warn
-        vi.mocked(console.warn).mockClear()
+        vi.mocked(consoleErrorSpy).mockClear()
         const customProvider3 = createMockProvider('custom3')
         manager.setTimeoutProvider(customProvider3)
-        expect(console.warn).not.toHaveBeenCalled()
+        expect(consoleErrorSpy).not.toHaveBeenCalled()
       })
     })
 

packages/query-core/src/timeoutManager.ts

@@ -68,29 +68,35 @@ export class TimeoutManager implements Omit<TimeoutProvider, 'name'> {
       return
     }
 
-    if (this.#providerCalled) {
-      // After changing providers, `clearTimeout` will not work as expected for
-      // timeouts from the previous provider.
-      //
-      // Since they may allocate the same timeout ID, clearTimeout may cancel an
-      // arbitrary different timeout, or unexpected no-op.
-      //
-      // We could protect against this by mixing the timeout ID bits
-      // deterministically with some per-provider bits.
-      //
-      // We could internally queue `setTimeout` calls to `TimeoutManager` until
-      // some API call to set the initial provider.
-      console.warn(
-        `[timeoutManager]: Switching to ${provider.name} provider after calls to ${this.#provider.name} provider might result in unexpected behavior.`,
-      )
+    if (process.env.NODE_ENV !== 'production') {
+      if (this.#providerCalled) {
+        // After changing providers, `clearTimeout` will not work as expected for
+        // timeouts from the previous provider.
+        //
+        // Since they may allocate the same timeout ID, clearTimeout may cancel an
+        // arbitrary different timeout, or unexpected no-op.
+        //
+        // We could protect against this by mixing the timeout ID bits
+        // deterministically with some per-provider bits.
+        //
+        // We could internally queue `setTimeout` calls to `TimeoutManager` until
+        // some API call to set the initial provider.
+        console.error(
+          `[timeoutManager]: Switching to ${provider.name} provider after calls to ${this.#provider.name} provider might result in unexpected behavior.`,
+        )
+      }
     }
 
     this.#provider = provider
-    this.#providerCalled = false
+    if (process.env.NODE_ENV !== 'production') {
+      this.#providerCalled = false
+    }
   }
 
   setTimeout(callback: TimeoutCallback, delay: number): ManagedTimerId {
-    this.#providerCalled = true
+    if (process.env.NODE_ENV !== 'production') {
+      this.#providerCalled = true
+    }
     return providerIdToNumber(
       this.#provider,
       this.#provider.setTimeout(callback, delay),
@@ -102,7 +108,9 @@ export class TimeoutManager implements Omit<TimeoutProvider, 'name'> {
   }
 
   setInterval(callback: TimeoutCallback, delay: number): ManagedTimerId {
-    this.#providerCalled = true
+    if (process.env.NODE_ENV !== 'production') {
+      this.#providerCalled = true
+    }
     return providerIdToNumber(
       this.#provider,
       this.#provider.setInterval(callback, delay),