Feature/thanks page picture #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Background images can now be fetched with url of type api/file/background-images/ - Thanks page images can now be fetched with url of type api/file/thanks-page-images/
jlaamanen
reviewed
Jun 27, 2023
|
|
||
| useEffect(() => { | ||
| async function getThanksPageImage() { | ||
| const res = await fetch( |
There was a problem hiding this comment.
[nit] Should this fetch actually only be used for fetching the headers? I believe you can fetch headers only with { method: 'HEAD' }.
The survey.thanksPage.imagePath could be used directly in the <img> tag's src attribute. Writing a megabytes long blob data into a data URL and rendering it after first downloading the image would probably be quite a slow task, especially on mobile devices
| } | ||
|
|
||
| function getActiveImage() { | ||
| const activeImage; |
There was a problem hiding this comment.
const variables shouldn't be re-assignable, I wonder why there are no errors here... 🤔 However, you can also return directly the results of images?.find(...) ?? null in both cases, no need for a variable for this.
jlaamanen
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to include a user defined image to thank you page. Uses SurveyImageList component which is also used for background image.
The backend offers an api endpoint with format api/file/<image_type>/<file_name>. All available images of certain type can be fetched using api/file/<image_type>.
Thank you page images are saved to the database to table data.files. Filepath column in the database is used to define the type of the image (background-images or thanks-page-images).
Closes #105