Skip to content

Commit

Permalink
Mark ordinal as safe for feedback cards
Browse files Browse the repository at this point in the history
Feedback cards show the position that submitting teams ranked in their
debate, but shows the HTML entities when the in-built ordinal
translations have HTML tags (e.g. French). This commit marks them as
safe to show the result of the HTML.
  • Loading branch information
tienne-B committed Dec 15, 2020
1 parent c8a1a21 commit f3d7a49
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tabbycat/adjfeedback/templates/feedback_card.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
From {{ source }} <span class="text-secondary small">(their {{ relationship }})</span>
{% endblocktrans %}
{% elif feedback.source_team %}
{% blocktrans trimmed with source=feedback.source_team.team.short_name relationship=feedback.source_team.get_result_display side=feedback.source_team.get_side_abbr %}
{% blocktrans trimmed with source=feedback.source_team.team.short_name relationship=feedback.source_team.get_result_display|safe side=feedback.source_team.get_side_abbr %}
From {{ source }} <span class="text-secondary small">({{ relationship }} from {{ side }})</span>
{% endblocktrans %}
{% else %}
Expand Down

2 comments on commit f3d7a49

@tienne-B
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotfix?

Note: Unrelated to #1691.

@czlee
Copy link
Member

@czlee czlee commented on f3d7a49 Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is hotfixable. If it's going to annoy someone at upcoming tournaments then it's okay to push immediately imho, otherwise hold till next patch.

Please sign in to comment.