Add field for participant in Submission

This commit adds a new field to Submission models as a Person foreign
key. This field is then populated when using private URLs as an
alternative to IP addresses (although still collected).

With this, ballots can be more easily distinguished from which
adjudicator had submitted the ballot. This is added to the "other
ballots" list. It can also be used to find which team member submitted
feedback, although not shown in any template.

Author: tienne-B

tabbycat/adjfeedback/views.py

@@ -560,6 +560,11 @@ def get_team_short_name(self, team):
     def is_page_enabled(self, tournament):
         return tournament.pref('participant_feedback') == 'private-urls'
 
+    def get_submitter_fields(self):
+        fields = super().get_submitter_fields()
+        fields['from_participant'] = self.object
+        return fields
+
     def get_success_url(self):
         # Redirect to non-cached page: their original private URL
         if isinstance(self.object, Adjudicator):

tabbycat/results/models.py

@@ -42,6 +42,11 @@ class Submission(models.Model):
     confirmed = models.BooleanField(default=False,
         verbose_name=_("confirmed"))
 
+    # relevant for private URL submissions
+    from_participant = models.ForeignKey('participants.Person', models.PROTECT,
+        blank=True, null=True,
+        verbose_name=_("from participant"))
+
     # only relevant if submitter was in tab room
     submitter = models.ForeignKey(settings.AUTH_USER_MODEL, models.PROTECT,
         blank=True, null=True, related_name="%(app_label)s_%(class)s_submitted",

tabbycat/results/templates/ballot/other_ballots_list.html

@@ -50,9 +50,15 @@ <h4 class="list-group-item-heading mb-0">
             entered by <strong>{{ submitter }}</strong>,
           {% endblocktrans %}
         {% elif other.submitter_type == ballotsub.SUBMITTER_PUBLIC %}
-          {% blocktrans trimmed with ip_address=other.ip_address %}
-            submitted from the public form on {{ ip_address }},
-          {% endblocktrans %}
+          {% if other.from_participant %}
+            {% blocktrans trimmed with adjudicator=other.from_participant %}
+              submitted from <strong>{{ adjudicator }}</strong>'s private URL,
+            {% endblocktrans %}
+          {% else %}
+            {% blocktrans trimmed with ip_address=other.ip_address %}
+              submitted from the public form on {{ ip_address }},
+            {% endblocktrans %}
+          {% endif %}
         {% endif %}
 
         {% blocktrans trimmed with timestamp=other.timestamp timeago=other.timestamp|timesince %}

tabbycat/results/views.py

@@ -559,6 +559,10 @@ class OldPublicNewBallotSetByRandomisedUrlView(SingleObjectByRandomisedUrlMixin,
     allow_null_tournament = True
     private_url = True
 
+    def populate_objects(self):
+        super().populate_objects()
+        self.ballotsub.from_participant = Adjudicator.objects.get(url_key=self.kwargs['url_key'])
+
     def get_success_url(self):
         return reverse_tournament('privateurls-person-index', self.tournament, kwargs={'url_key': self.kwargs['url_key']})