[BUG] Backend summary output settings are merged

[ayacoo]

Describe the bug
If you create several result plugins on a TYPO3 page with different settings, then these settings are merged down in the backend output for the plugins and thus output incorrectly.

This file is the trigger: https://github.com/TYPO3-Solr/ext-solr/blob/main/Classes/Backend/SettingsPreviewOnPlugins.php

Here $this->settings is used, which would probably have to be reset with __invoke.
Alternatively, you can also add an intermediate level to $this->settings: $this->settings[$this->pluginsTtContentRecord['uid']]

To Reproduce
Steps to reproduce the behavior:

1. Create two result plugins with different settings on one TYPO3 page

Used versions (please complete the following information):

• TYPO3 Version: 12.4.21
• EXT:solr Version: 12.0.5
• PHP Version: 8.3

[dkd-kaehm]

@ayacoo
Thanks for reporting that issue.
Could you provide a PR, against release-12.0.x branch?

[dkd-kaehm]

That is strange, SettingsPreviewOnPlugins is not a singleton, therefore is it a TYPO3 Core bug?

OK, that is defined in Services.yaml:

ext-solr/Configuration/Services.yaml

Lines 53 to 61 in dc7162b

	# BE modules, plugins
	ApacheSolrForTypo3\Solr\Backend\SettingsPreviewOnPlugins:
	arguments:
	$flexFormService: '@TYPO3\CMS\Core\Service\FlexFormService'
	tags:
	- name: event.listener
	identifier: 'solr.plugin.be.settings.preview'
	event: TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent
	# END: BE modules

Is there a way to set DI to always deliver new instances?

[ayacoo]

@dkd-kaehm Unfortunately, I am not aware of this DI topic. I would prefer the variant with the integration of the Content UID in the settings array. What is your opinion?

Basically, this event listener integration is working.

[dkd-kaehm]

@dkd-kaehm Unfortunately, I am not aware of this DI topic. I would prefer the variant with the integration of the Content UID in the settings array. What is your opinion?

Basically, this event listener integration is working.

Preferred way is to make that class to "Data object"-Type aka non singleton.
To avoid the hacks to reset state. The SettingsPreviewOnPlugins-Object is not necessary anymore after it did its job.

[dkd-kaehm]

@bmack
Is there a way in Services.yaml to mark/define the things as data object?

[bmack]

"Is there a way to set DI to always deliver new instances?"

Services are shared (= same instance all the time) by default. In "classic" TYPO3-speak this is similar to SingletonInterface as we know from the past, but done in Configuration, not via a Marker interface.

So, to achieve this to always get a new instance, you need to set shared: false in Services.yaml.

[dkd-kaehm]

@bmack thanks.

So, to achieve this to always get a new instance, you need to set shared: false in Services.yaml.

@ayacoo ;)
Please try it:

# BE modules, plugins 
 ApacheSolrForTypo3\Solr\Backend\SettingsPreviewOnPlugins: 
   arguments: 
     $flexFormService: '@TYPO3\CMS\Core\Service\FlexFormService' 
   tags: 
     - name: event.listener 
       identifier: 'solr.plugin.be.settings.preview' 
       event: TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent
   shared: false
 # END: BE modules