Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency in testclasses.php #18

Open
mindplay-dk opened this issue Aug 22, 2015 · 3 comments
Open

Circular dependency in testclasses.php #18

mindplay-dk opened this issue Aug 22, 2015 · 3 comments

Comments

@mindplay-dk
Copy link

It looks like you have a circular dependency here, e.g. K depends on K.

Is that deliberate?

@njasm
Copy link
Contributor

njasm commented Aug 22, 2015

@mindplay-dk I've also notice that when I was optimizing the tests #17 for the latest version of my DiC .
but i didn't find any test actually using the K class...

maybe @TomBZombie could share some light on the matter?

@mindplay-dk
Copy link
Author

Yeah, looks like it's actually unused, I noticed that as well - probably just left there by accident.

@TRPB
Copy link
Owner

TRPB commented Aug 22, 2015

Indeed, I did have a benchmark which looked at containers handling circular dependencies, however as not all of them actually support it I had to remove it entirely. I'll remove the unused class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants