Improve implementation of AddTypesToNamespaces loader task #416
+11
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Linne <[email protected]>
alexanderlinne
force-pushed
the
refactor/add-types-to-namespaces-lodader-task
branch
from
4ee5626 to
987d366
Compare
mak638
approved these changes
Sep 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
- Coverage 74.84% 74.84% -0.01%
==========================================
Files 257 257
Lines 17224 17221 -3
Branches 1574 1575 +1
==========================================
- Hits 12892 12889 -3
Misses 3876 3876
Partials 456 456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexanderlinne
deleted the
refactor/add-types-to-namespaces-lodader-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large architectures, a large number of
AddTypesToNamespaceinstance were created. With this PR, only one instance per Module is created.