Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure intermediate cached objects are boxed correctly. #39

Open
felix-schultz opened this issue Mar 21, 2025 · 0 comments
Open

Make sure intermediate cached objects are boxed correctly. #39

felix-schultz opened this issue Mar 21, 2025 · 0 comments
Assignees
@felix-schultz
Labels
enhancement New feature or request

Comments

@felix-schultz
Copy link
Member

For most cached objects we actually want to share a more complex object with other nodes. An example would be a Database Connection that stays open. Make sure that these values are correctly wrapped in Arc<Mutex<..>> or Arc<RwLock<..>>.

A positive example are the vector store nodes.
@felix-schultz felix-schultz added the enhancement New feature or request label Mar 21, 2025
@felix-schultz felix-schultz self-assigned this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felix-schultz felix-schultz

Labels
enhancement New feature or request
Projects
Flow-Like
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felix-schultz