Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] extension_tester_t still missed send_audio_frame/send_video_frame #321

Closed
wangyoucao577 opened this issue Nov 24, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@wangyoucao577
Copy link
Collaborator

Description

https://github.com/TEN-framework/ten_framework/blob/main/core/include/ten_runtime/binding/cpp/internal/test/env_tester.h

The extension_tester_t will be used in extension testing, which requires send_audio_frame/send_video_frame but doesn't exist.

Environment

linux

Steps to reproduce

  1. expect the use send_audio_frame/send_video_frame in extension testing, but the apis don't exist.

Expected behavior

send_audio_frame/send_video_frame exist.

Actual behavior

send_audio_frame/send_video_frame don't exist.

Version

0.4.2

Severity

Critical

Additional Information

No response

@wangyoucao577 wangyoucao577 added the bug Something isn't working label Nov 24, 2024
@wangyoucao577
Copy link
Collaborator Author

By the way, the extension_tester_t is part of API, which doesn't supposed in the internal folder.

@halajohn halajohn self-assigned this Nov 26, 2024
@sunxilin sunxilin self-assigned this Nov 26, 2024
@sunxilin
Copy link
Collaborator

send_audio/video_frame apis are provided in main branch now.

@halajohn
Copy link
Member

The two PRs below should resolve this issue.

C++ test-related header files are also included in the unified ten.h for developers to use. The internal/ directory represents header files that are referenced internally by ten.h and are not meant for internal use in the typical sense. However, to avoid confusion, the internal/ folder name has been changed to detail/ in the above PRs to better align with C++ naming conventions.

@github-project-automation github-project-automation bot moved this to Done in Kanban Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants