Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit logic for deleting grant-authorized records when handling a permission revocation RecordsWrite #716

Open
thehenrytsai opened this issue Mar 29, 2024 · 0 comments
Open

Revisit logic for deleting grant-authorized records when handling a permission revocation RecordsWrite #716

thehenrytsai opened this issue Mar 29, 2024 · 0 comments
Labels
bug Something isn't working testing related to new or existing tests

Comments

@thehenrytsai
Copy link
Member

Revisit logic in postProcessingForCoreRecordsWrite() for deleting grant-authorized records when handling a permission revocation RecordsWrite.

It appears that there was no test for it and it does not look like the code worked:

  • not seeing permissionsGrantId being an index
  • not seeing this.dataStore being called to delete actual data
  • test coverage is missing for the main delete logic
@thehenrytsai thehenrytsai added bug Something isn't working testing related to new or existing tests labels Mar 29, 2024
@thehenrytsai thehenrytsai mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working testing related to new or existing tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehenrytsai