From 89e5183344e8b5d23cf6b29a0d649c80425da90e Mon Sep 17 00:00:00 2001 From: Jarosenb Date: Fri, 3 Jun 2022 10:05:36 -0500 Subject: [PATCH 1/4] add Github Actions and PR template --- .github/pull_request_template.md | 15 +++++++++++++++ .github/workflows/main.yml | 22 ++++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 .github/pull_request_template.md create mode 100644 .github/workflows/main.yml diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..70dd8a5aa --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,15 @@ +## Overview: + +## Related Github Issues: + +- [TUP-1234](https://jira.tacc.utexas.edu/browse/TUP-1234) + +## Summary of Changes: + +## Testing Steps: + +1. + +## UI Photos: + +## Notes: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 000000000..2945c4df7 --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,22 @@ +name: CI +on: + push: + branches: + - main + pull_request: + +jobs: + main: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + with: + fetch-depth: 0 + - uses: nrwl/nx-set-shas@v2 + - run: npm ci + + - run: npx nx workspace-lint + - run: npx nx format:check + - run: npx nx affected --target=lint --parallel=3 + - run: npx nx affected --target=test --parallel=3 --ci --code-coverage + - run: npx nx affected --target=build --parallel=3 \ No newline at end of file From cf1e2296a138b260d1265adc248fb19722c53083 Mon Sep 17 00:00:00 2001 From: Jarosenb Date: Fri, 3 Jun 2022 10:09:00 -0500 Subject: [PATCH 2/4] apply formatting --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 2945c4df7..e3617ecc0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -19,4 +19,4 @@ jobs: - run: npx nx format:check - run: npx nx affected --target=lint --parallel=3 - run: npx nx affected --target=test --parallel=3 --ci --code-coverage - - run: npx nx affected --target=build --parallel=3 \ No newline at end of file + - run: npx nx affected --target=build --parallel=3 From e591912df2ca09243a6dfb18afdb133464227030 Mon Sep 17 00:00:00 2001 From: Jarosenb Date: Fri, 3 Jun 2022 10:21:17 -0500 Subject: [PATCH 3/4] add comments to action runner --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e3617ecc0..4b3eb22ee 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,8 +15,11 @@ jobs: - uses: nrwl/nx-set-shas@v2 - run: npm ci + # Check linting/formatting of workspace files - run: npx nx workspace-lint - run: npx nx format:check + + # Lint/test/build any apps and libs that have been impacted by the diff. - run: npx nx affected --target=lint --parallel=3 - run: npx nx affected --target=test --parallel=3 --ci --code-coverage - run: npx nx affected --target=build --parallel=3 From 70165b8ce29d97d684c66c063121a7b8744b2e1d Mon Sep 17 00:00:00 2001 From: Jake Rosenberg Date: Fri, 3 Jun 2022 10:25:02 -0500 Subject: [PATCH 4/4] Apply suggestions from code review Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com> --- .github/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 70dd8a5aa..fbc6e8b5a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,15 +1,15 @@ ## Overview: -## Related Github Issues: +## Related: - [TUP-1234](https://jira.tacc.utexas.edu/browse/TUP-1234) -## Summary of Changes: +## Changes: -## Testing Steps: +## Testing: 1. -## UI Photos: +## UI: ## Notes: