Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Menu Open Toggle Diff Size on CMS and Portal → FP-1459 #55

Closed
wesleyboar opened this issue Jan 21, 2021 · 1 comment · Fixed by #225 · May be fixed by #222
Closed

Nav Menu Open Toggle Diff Size on CMS and Portal → FP-1459 #55

wesleyboar opened this issue Jan 21, 2021 · 1 comment · Fixed by #225 · May be fixed by #222
Labels
bug Something isn't working priority ▼ Low priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Jan 21, 2021 •
edited
Loading

Status

Migrated to FP-1459.

Archived

In GitLab by @tacc-wbomar on Nov 23, 2020, 11:50

Summary

On narrow screen view of Portal and CMS, the hamburger is a different size.

Reference

Header_Narrow_Screen_-_Portal

Header_Narrow_Screen_-_CMS

Direction

Portal has different root font-size than CMS, which is a known issue that is resolved in two ways:

  • code we write: do not use rem (until problem is fixed)
  • code we borrow (Bootstrap): overwrite as necessary (and do not use rem)
@wesleyboar wesleyboar added bug Something isn't working priority ▼ Low priority labels Jan 21, 2021
@wesleyboar wesleyboar mentioned this issue Jan 29, 2021
Closed
This was linked to pull requests May 18, 2021
GH-101/FP-1458: Header Redesign #222
Draft
GH-101: Navigation Bar (Sans Search & Portal Nav Button) #225
Merged
@wesleyboar wesleyboar mentioned this issue May 18, 2021
Merged
@wesleyboar wesleyboar changed the title Nav Menu Open Toggle Diff Size on CMS and Portal Nav Menu Open Toggle Diff Size on CMS and Portal → FP-1459 Jan 12, 2022
@wesleyboar
Copy link
Member Author

Migrated to FP-1459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority ▼ Low priority
Projects
None yet
Milestone
No milestone
1 participant
@wesleyboar