Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: indicate origin of mets and rxns added in recent updates #161

Closed
7 tasks done
BenjaSanchez opened this issue Sep 17, 2018 · 1 comment
Closed
7 tasks done
Assignees
Labels
enhancement new field/feature fixed in devel this issue is already fixed in devel and will be closed after the next release format fix things associated to format of any of the model/data/script files

Comments

@BenjaSanchez
Copy link
Contributor

BenjaSanchez commented Sep 17, 2018

Following what we made in PR #156, we should include both in metNotes or rxnNotes why were the corresponding mets/rxns added for the following past updates to the model:

For consistency, we should also update the notes added in #156:

I hereby confirm that I have:

  • Done this analysis in the master branch of the repository
  • Checked that a similar issue does not exist already
  • If needed, asked first in the Gitter chat room about the issue
@BenjaSanchez BenjaSanchez added format fix things associated to format of any of the model/data/script files enhancement new field/feature labels Sep 17, 2018
@feiranl feiranl mentioned this issue Oct 16, 2018
3 tasks
@BenjaSanchez
Copy link
Contributor Author

update: this was completed in PR #170, this issue will be closed on next release

@BenjaSanchez BenjaSanchez added the fixed in devel this issue is already fixed in devel and will be closed after the next release label Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new field/feature fixed in devel this issue is already fixed in devel and will be closed after the next release format fix things associated to format of any of the model/data/script files
Projects
None yet
Development

No branches or pull requests

2 participants