Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GEM-specific PRs when changes are introduced into the ecModels repository files #57

Open
1 of 3 tasks
IVANDOMENZAIN opened this issue Feb 19, 2021 · 2 comments
Open
1 of 3 tasks
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@IVANDOMENZAIN
Copy link
Member

IVANDOMENZAIN commented Feb 19, 2021

In the current implementation of the automated workflow, the GECKO pipeline is programmed to run exclusively on GEMs whose version has changed,or for all models if any of the dependencies changes its version. This situation will eventually make that, when changes are introduced into any file in this repository, GEM-specific PRs are not gonna be created because a change in the source model version are not taking place.

Therefore, we need that our pipeline is able to run and create PRs for a model, every time that:

  • A change in the source model version is detected by a scheduled run.
  • When changes in the GECKO toolbox are detected by a scheduled run (new release).
  • When changes are introduced into the ecModels repo (push events to branches other than master and update...)
@IVANDOMENZAIN IVANDOMENZAIN self-assigned this Feb 19, 2021
@IVANDOMENZAIN IVANDOMENZAIN added enhancement New feature or request help wanted Extra attention is needed labels Feb 19, 2021
@mihai-sysbio
Copy link
Member

mihai-sysbio commented Feb 28, 2021

For even more accuracy, I'd consider rephrasing

or for all models if GECKO changes its version

to

or for all models if any of the dependencies changes its version.

@mihai-sysbio
Copy link
Member

  • A change in the source model version is detected by a scheduled run.

I think this is already implemented - every time the latest tag changes, the pipeline is triggered, see here.

  • When changes in the GECKO toolbox are detected by a scheduled run (new release).

This is already implemented here.

Therefore, I think this issue is solved and it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants