Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive UnusedLetBind in the presence of inherit #61

Open
whentze opened this issue Nov 11, 2021 · 0 comments · May be fixed by #62
Open

False positive UnusedLetBind in the presence of inherit #61

whentze opened this issue Nov 11, 2021 · 0 comments · May be fixed by #62

Comments

@whentze
Copy link

whentze commented Nov 11, 2021

Issue

This input:

let
  foo = { bar = ""; };
  inherit (foo) bar;
in
  bar

results in this lint:

Unused `let` bind `foo` at linter-repro.nix:2:3

However, removing the let-binding (unsurprisingly) breaks the inherit.

Affected Versions

I tested this on current git master (ecdd507) and the version available in nixpkgs 21.05 (2516a8c).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix UnusedLetBind: account for inherit Radvendii/nix-linter
1 participant
@whentze