Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up package.json dependencies #53

Open
dguo opened this issue Oct 3, 2019 · 1 comment
Open

Clean up package.json dependencies #53

dguo opened this issue Oct 3, 2019 · 1 comment

Comments

@dguo
Copy link

dguo commented Oct 3, 2019

  1. axios appears in devDependencies, peerDependencies, and dependencies. Since it's required at run time, it seems like it only needs to be in dependencies.

  2. lodash is in devDependencies and peerDependencies, but it's required in buildUrls.js, so it seems like it should be in dependencies.

Peer dependencies are best used for plugins.
@p-herbert
Copy link

To follow-up with @dguo's comment this causes significant build issues. We had to include lodash in our service's package dependencies for everything to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dguo @p-herbert