Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable output order #33

Open
litghost opened this issue Dec 4, 2019 · 1 comment
Open

Unstable output order #33

litghost opened this issue Dec 4, 2019 · 1 comment

Comments

@litghost
Copy link
Contributor

litghost commented Dec 4, 2019

The code generator generate functions in an order that is dependent on the hash order from python, which is unstable. This causes unneeded diffs when re-running the generator.

In generally, function output order should be constant when possible.
@duck2
Copy link
Member

duck2 commented Dec 4, 2019 •
edited
Loading

The complex types are sorted in the schema according to tree height. Maybe the order between types with equal tree height is varying? Should we also sort alphanumerically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@litghost @duck2