Improve AWS bedrock integration #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was literally about to make a PR to fix the list model method. Looks like you beat me to it. |
6 tasks
|
@ajithvcoder Hi, are you able to adapt this to work with this new PR for streaming in bedrock and also have no merge conflicts ? |
|
@ajithvcoder the tests i wrote in #314 are an adaptation of yours. So it should just work with your code. |
…for aws bedrock integration
ajithvcoder
force-pushed
the
feature_bedrock_improve
branch
from
0ba9498 to
8ef0893
Compare
|
@fm1320 the merge conflicts are fixed and #314 is already working fine as @lloydhamilton told. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
aws_profile_nameandaws_region_namelist_models()and added support to pass arguments for specific model fetchingconvert_inputs_to_api_kwargs()to acceptmodelasmodelIdandmax_tokensasmaxTokensinternallyinferenceConfigandadditionalModelRequestFieldsaws_bedrock.rstfile for documentationtutorials\bedrock_client_simple_qa.pyfor showing usage exampletutorials\generator_all_providers.pyFixes #283
Before submitting
Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline? yes
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary) Yes
Did you write any new necessary tests? (not for typos and docs) Yes i have added mock tests and
tutorials\bedrock_client_simple_qa.pyDid you verify new and existing tests pass locally with your changes? Yes
Did you list all the breaking changes introduced by this pull request? There is no breaking changes