-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply consistent coding and documenting styling #273
Comments
Doesn't just running the pre-commit hooks locally (black and ruff) ensure this consistency ? |
If that is the case, how did your pr results so many different files? |
I ran the pre-commit hooks on all files before committing so the changes are white spaces and formatting that the linter enforced - I only modified one file in my PR |
there is no black and ruff config in the pyproject.toml. Maybe your configuration and the others somehow end up being different. Ill add a simple version and you can rebase on this, and try to use the format and test if those files can be set back |
Feel free to review, merge and test it on your side You can use make setup and make format, make lint etc |
Yes I assumed that the fact that they were part of the |
I ran the pre-commit hooks suggested on all files, made the changes 3196631. Maybe this can be merged and then the styling will be consistent ? @liyin2015 |
|
Outline & Motivation
Without enforcing the same formatting, developers end up committing code/files that only changes formatting, making it hard to review.
Pitch
We might need a
Makefile
and add either the formatting here and modify the rootpyproject.toml
, as described in the contributor guide that commit hook is applied here.Additional context
No response
The text was updated successfully, but these errors were encountered: