Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Memory is Missing the required 'call' method #248

Open
J-Fo-S opened this issue Oct 30, 2024 · 0 comments
Open

Component Memory is Missing the required 'call' method #248

J-Fo-S opened this issue Oct 30, 2024 · 0 comments
Labels
[adalflow] suggest improvement Improve existing functionality (non-integration] in /adalflow good first issue Good for newcomers help wanted Need helps with input, discussion, review, and PR submission.

Comments

@J-Fo-S
Copy link

J-Fo-S commented Oct 30, 2024 •
edited
Loading

Describe the bug
The adalflow.components.memory.memory.Memory class seems to have been left unfinished without a call method.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/SylphAI-Inc/AdalFlow/blob/main/use_cases/question_answering/chatbot.ipynb
  2. Replace deprecated from adalflow.core.memory import Memory with from adalflow.components.memory.memory import Memory
  3. Run program

Expected behavior
Call method
@liyin2015 liyin2015 added [adalflow] suggest improvement Improve existing functionality (non-integration] in /adalflow good first issue Good for newcomers help wanted Need helps with input, discussion, review, and PR submission. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[adalflow] suggest improvement Improve existing functionality (non-integration] in /adalflow good first issue Good for newcomers help wanted Need helps with input, discussion, review, and PR submission.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liyin2015 @J-Fo-S