Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Reforge System #352

Open
ItzKatze opened this issue Jul 6, 2024 · 3 comments
Open

[IMPROVEMENT] Reforge System #352

ItzKatze opened this issue Jul 6, 2024 · 3 comments

Comments

@ItzKatze
Copy link
Contributor

ItzKatze commented Jul 6, 2024

currently reforge statistics are calculated with a formula which isn't possible with most reforges (net.swofty.commons.item.ReforgeType).
Instead, hardcode the numbers which leads to way easier adjusting when hypixel changes their numbers again.

@Swofty-Developments
Copy link
Owner

The way that reforgetype works allows you to just have a switch statement in there, essentially hardcoding it. I just haven't happened to do that and instead wrote some equations.

@ItzKatze
Copy link
Contributor Author

ItzKatze commented Jul 6, 2024

net.swofty.types.generic.utility.RarityValue would be ideal for this but since ReforgeType is in commons switches is prob the way to go

@ItzKatze
Copy link
Contributor Author

this is done^^ but following things also need to be done:

  • supporting reforges being able to put on multiple types of tools
  • reforge stones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants