Skip to content

Conversation

@stevapple
Copy link
Contributor

  (node:721) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
  (Use `node --trace-deprecation ...` to show where the warning was created)

@soumyamahunt
Copy link
Contributor

@stevapple unit tests are failing, could be due to the API usage change and might require updating some mocks. Please make the changes applicable.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b6ac81d) 91.41% compared to head (0787f3c) 91.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          30       30           
  Lines         897      897           
  Branches      122      122           
=======================================
  Hits          820      820           
  Misses         76       76           
  Partials        1        1           
Files Coverage Δ
src/swiftorg.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@soumyamahunt soumyamahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyamahunt soumyamahunt merged commit 214f7e8 into SwiftyLab:main Sep 26, 2023
@stevapple stevapple deleted the rmdir-to-rm branch September 26, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants