Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please adapt to changes in iOS17 & macOS 14 #2

Closed
nkalvi opened this issue Jul 13, 2023 · 3 comments
Closed

Please adapt to changes in iOS17 & macOS 14 #2

nkalvi opened this issue Jul 13, 2023 · 3 comments

Comments

@nkalvi
Copy link

nkalvi commented Jul 13, 2023

public var id: String { identifier }

Please update this to work with upcoming changes:
id | Apple Developer Documentation

@objc
dynamic var id: UUID { get }
Relationships
From Protocol
Identifiable

@shaps80
Copy link
Contributor

shaps80 commented Jul 17, 2023

I already fixed this in the latest release. Contributions always welcome btw, rather than demands ;)

@shaps80 shaps80 closed this as completed Jul 17, 2023
@nkalvi
Copy link
Author

nkalvi commented Jul 17, 2023

I'm sorry, didn't realize I sounded demanding ;)

1.2.0 fails to compile:

Command SwiftCompile failed with a nonzero exit code

/Connections/Fetch/FetchContact.swift:23:31 'ID' is only available in iOS 17 or newer
/Connections/Fetch/FetchContactList.swift:118:33 'ID' is only available in iOS 17 or newer
/Connections/Fetch/FetchContainerList.swift:57:42 'ID' is only available in iOS 17 or newer
/Connections/Support/Identifiable.swift:4:1 Type 'CNContact' does not conform to protocol 'Identifiable'

I'll submit a PR later.

@shaps80
Copy link
Contributor

shaps80 commented Jul 23, 2023

Appreciate it. I’m surprised as I saw this and thought I’d resolved. Perhaps the fix only worked in the previous beta. Thansk.

@nkalvi nkalvi mentioned this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants