Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Swift 4 templates #63

Closed
djbe opened this issue Jul 21, 2017 · 2 comments
Closed

Swift 4 templates #63

djbe opened this issue Jul 21, 2017 · 2 comments

Comments

@djbe
Copy link
Member

djbe commented Jul 21, 2017

As mentioned in SwiftGen/SwiftGen#312 by @csnu17, there apparently are some issues with the current templates on swift 4.

We should fix these errors(*), and if possible, use new language features to simplify the templates where needed.

(*) more accurately, create a new swift4 template—based on the swft3 templates but with fixes to make it compile to Swift 4— so that we'll keep both swift3 and swift4 templates for the users of SwiftGen to choose from

@djbe djbe added this to the Nice To Have milestone Jul 21, 2017
@AliSoftware
Copy link
Collaborator

There's currently a note in the README mentioning that "we don't have Swift 4 templates yet but they are coming soon"; reminder that we should obviously not forget to remove that note once this issue is implemented.

@djbe
Copy link
Member Author

djbe commented Aug 12, 2017

@csnu17 SwiftGen 5 was released today. Could you provide some sample code where the current swift 3 template fails when using swift 4 code? From cursory testing in playgrounds, everything seems to work for me.

@djbe djbe mentioned this issue Aug 13, 2017
@djbe djbe modified the milestones: 2.1.0, Nice To Have Aug 13, 2017
@djbe djbe closed this as completed in #67 Aug 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants