Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface Builder: support "inherit module from target" setting #435

Closed
djbe opened this issue May 29, 2018 · 0 comments
Closed

Interface Builder: support "inherit module from target" setting #435

djbe opened this issue May 29, 2018 · 0 comments

Comments

@djbe
Copy link
Member

djbe commented May 29, 2018

Refs #405, #443.

While dealing with multi-target storyboards today, I saw the following entry in the IB XML:

<viewController id="0fr-m9-z70" customClass="FiltersViewController" customModule="Graco" customModuleProvider="target" sceneMemberID="viewController">

When the "Inherit module from target" flag is set in IB, the XML for that scene is modified, the attribute customModuleProvider="target" is added. When it is toggled of, the attribute is completely removed. Supporting this attribute would solve all our issues with modules I think (hope)?

Suggested workflow:
Modify the IB parser to check for this attribute. If found, replace the value for customModule with whatever's in the CURRENT_PRODUCT_MODULE env. variable. If that env. variable is not set, don't replace anything.

@djbe djbe changed the title IB: support customModuleProvider Interface Builder: support customModuleProvider Sep 6, 2018
@djbe djbe changed the title Interface Builder: support customModuleProvider Interface Builder: support "inherit module from target" setting Sep 6, 2018
@djbe djbe closed this as completed in #485 Sep 10, 2018
@djbe djbe added this to the Swiftgen 6.0 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant