Split rakefile into parts #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
force-pushed
the
feature/rakelib
branch
from
5295e26
to
051ec87
Compare
AliSoftware
requested changes
Feb 28, 2017
There was a problem hiding this comment.
Same global remarks as in SwiftGen/SwiftGen#269 (review) especially about:
- calling
$?.success?as close as possible as the shell command for which we want to test the exit code - finding better names for
xcrunvsxcprettyvsplainfunctions (especially that last one), or even make it one single function (e.g.run_cmd) with appropriate parameters
djbe
force-pushed
the
feature/rakelib
branch
2 times, most recently
from
e5b69aa
to
4911510
Compare
djbe
force-pushed
the
feature/rakelib
branch
from
3764cd2
to
db61e5e
Compare
AliSoftware
reviewed
Mar 1, 2017
| class Utils | ||
|
|
||
| # run a command using xcrun and xcpretty if applicable | ||
| def self.run(cmd, task, subtask = '', xcrun: false, xcpretty: false, direct: false) |
There was a problem hiding this comment.
xcpretty and direct are mutually exclusive (i.e. the API technically allows you to call xcpretty: true, direct: true while it wouldn't make sense).
In a future version, maybe use a symbol instead, like formatter: :xcpretty vc formatter: :none vs formatter: :direct? (Although the difference between direct and none wouldn't be obvious so we'd need to find better names)
I'll let that small refactoring for the future PR in Eve consolidating rakelib accross repos though, so we can merge this now.
AliSoftware
approved these changes
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check how we can repeat these across repositories and keep them in sync. Right now there are some small differences due to layout differences and different requirements.