Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIP-007 #13

Closed
Swader opened this issue Feb 4, 2021 · 1 comment
Closed

RIP-007 #13

Swader opened this issue Feb 4, 2021 · 1 comment
Labels
RIP RMRK Improvement Proposal

Comments

@Swader
Copy link
Contributor

Swader commented Feb 4, 2021

RIP Summary

With the addition of the version into the RMRK itself, the version inside the collection's data becomes unnecessary and is just dead data weight. This RIP proposes the removal of the version from the collection's data.

RIP Details

Previously, the MINT interaction looked like this:

rmrk::MINT::htmlencoded(JSON_OF_COLLECTION)

Now, the interaction is:

rmrk::MINT::RMRK1.0.0::htmlencoded(JSON_OF_COLLECTION)

With that, JSON_OF_COLLECTION does not need the collection's version field, and as such the Collection entity also does not need it.

This applies to NFT minting as well.

Impact

As this is going into V1 onward, it should not cause any problems. Even if the version is still included in the data objects, it will just cost more but do no damage.

@Swader Swader added the RIP RMRK Improvement Proposal label Feb 4, 2021
@Swader
Copy link
Contributor Author

Swader commented Feb 5, 2021

Closed in #7

@Swader Swader closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RIP RMRK Improvement Proposal
Projects
None yet
Development

No branches or pull requests

1 participant