GET product reviews request with an invalid value of param "product_rating" the system returns all product reviews. #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Prankurtiwari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If "%" is pass then system doesn't receive it making
List<Integer> productRatingnull, that passes all the validation and display all the relevant records.LinkProposed Solution
Added a validation for null
List<Integer> productRatingso that user get the error message to add rating.If we want to pass actual "%" then the correct way is passing
%25. FYI system request that request.Ripple Effect
Adding that check will change the non required productRating as it is a required field now.
Problem in Hand
How backend system will distinguished
CASE1: productRating = %
CASE2: (productRating not sent)
as for that system both are null.