Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace qs #70

Closed
gkiely opened this issue Jun 23, 2024 · 2 comments
Closed

Replace qs #70

gkiely opened this issue Jun 23, 2024 · 2 comments

Comments

@gkiely
Copy link

gkiely commented Jun 23, 2024

Imports 14 dependencies
https://npm.anvaka.com/#/view/2d/qs
ljharb/qs#404

@mikkurogue
Copy link

mikkurogue commented Jun 23, 2024

All 14 dependencies are also authored by our friend lol...

I'll see if I can find some time to find a replacement and do my part in cleaning.

@SukkaW
Copy link
Owner

SukkaW commented Jun 24, 2024

Actually, we don't have to replace the entire qs.

https://npmgraph.js.org/?q=qs

image

As you can see, the toxic dependency is the side-channel that brings all its friends.

And nolyfill already handles side-channel by providing @nolyfill/side-channel: https://github.com/SukkaW/nolyfill/tree/93c7c4aace6d8e51b4c734f4d6d84fe9d0df8a2b/packages/generated/side-channel

@mikkurogue This info should help you if you want to submit a PR to qs or create a fork!

I am going to close the issue since we already have @nolyfill/side-channel. But if qs introduce any other new toxic dependencies, feel free to create a new issue or ping me to re-open this one!

@SukkaW SukkaW closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants