-
-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a href with image #121
Comments
Hey can you please post your code of the Html Widget. |
|
Same problem here, a href with image when is clicked fires onImageTap event and not onLinkTap. |
Yup, this is definitely an issue. I'll work to make sure that the |
I have the same issue. Hopefully the fix can be released soon. Currently I'm using a complicated workaround. Thanks a lot! |
This issue exists in the default parser as well as the RichText parser. @Sub6Resources - this issue is really unfortunate because the current onImageTap callback only provides the image URL that is clicked. Often times, an image is used as a button or CTA and needs to open another URL. Would you consider prioritizing this issue? Currently, the only workaround I can think of is adding the open url to a query parameter and extracting that value. |
This has been fixed in version 1.0.0 and will be released by the end of the month. See #122 for progress on the 1.0.0 release. |
As a note, the fix makes it so that both of the callbacks ( |
@Sub6Resources thanks for the fix! Is there a way to suppress |
Not currently, I may consider adding that though. What is your use-case for detecting onLinkTap and suppressing onImageTap? |
I have user content, namely I render parsed markdown content. Users sometimes embed images which I'd like to provide a lightbox for on tap. But sometimes users also wrap the image embed with a link for example for a link banner or a link to their own gallery page etc. In this case I want to open just the link and not show the lightbox. |
Guess I should open a new issue for the above so it doesn't get lost? |
Good morning,
a image as a link is not clickable.
<a href="www.google.de"><img src="https://image.de"></a>
can you fix it? =)
kind regards
The text was updated successfully, but these errors were encountered: