New global site search box #622
Comments
|
Here's how it looks while doing a search <ul class="js-navigation-container jump-to-suggestions-results-container js-jump-to-suggestions-results-container js-active-navigation-container">
<li class="d-flex flex-justify-start flex-items-center p-0 f5 navigation-item js-navigation-item navigation-focus">
<a class="no-underline d-flex flex-auto flex-items-center p-2 jump-to-suggestions-path js-jump-to-suggestion-path js-navigation-open" aria-label="Jump to..." href="https://github.com/StylishThemes/GitHub-Dark/search?q=github&unscoped_q=github" data-target-type="Search" data-target-id="0" data-client-rank="0" data-server-rank="0">
<div class="jump-to-octicon js-jump-to-octicon mr-2 text-center"><svg height="16" width="16" class="octicon octicon-search flex-shrink-0 js-jump-to-search-octicon-template" title="Search" viewBox="0 0 16 16" version="1.1" aria-hidden="true"><path fill-rule="evenodd" d="M15.7 13.3l-3.81-3.83A5.93 5.93 0 0 0 13 6c0-3.31-2.69-6-6-6S1 2.69 1 6s2.69 6 6 6c1.3 0 2.48-.41 3.47-1.11l3.83 3.81c.19.2.45.3.7.3.25 0 .52-.09.7-.3a.996.996 0 0 0 0-1.41v.01zM7 10.7c-2.59 0-4.7-2.11-4.7-4.7 0-2.59 2.11-4.7 4.7-4.7 2.59 0 4.7 2.11 4.7 4.7 0 2.59-2.11 4.7-4.7 4.7z"></path></svg></div>
<img class="avatar mr-2 flex-shrink-0 js-jump-to-suggestion-avatar d-none" alt="" src="" width="28" height="28">
<div class="jump-to-suggestion-name js-jump-to-suggestion-name flex-auto overflow-hidden no-wrap css-truncate css-truncate-target">github</div>
<div class="border rounded-1 flex-shrink-0 bg-gray px-1 text-gray-light ml-1 f6 d-on-nav-focus js-jump-to-badge-search">
In this repository
<span class="d-inline-block ml-1 v-align-middle">?</span>
</div>
<div class="border rounded-1 flex-shrink-0 bg-gray px-1 text-gray-light ml-1 f6 d-none d-on-nav-focus js-jump-to-badge-jump">
Jump to
<span class="d-inline-block ml-1 v-align-middle">?</span>
</div>
</a>
</li>
<li class="d-flex flex-justify-start flex-items-center p-0 f5 navigation-item js-navigation-item">
<a class="no-underline d-flex flex-auto flex-items-center p-2 jump-to-suggestions-path js-jump-to-suggestion-path js-navigation-open" aria-label="Jump to..." href="/StylishThemes/GitHub-Dark" data-target-type="Repository" data-target-id="1219740" data-client-rank="0" data-server-rank="1">
<div class="jump-to-octicon js-jump-to-octicon mr-2 text-center"><svg height="16" width="16" class="octicon octicon-repo flex-shrink-0 js-jump-to-repo-octicon-template" title="Repository" viewBox="0 0 12 16" version="1.1" aria-hidden="true"><path fill-rule="evenodd" d="M4 9H3V8h1v1zm0-3H3v1h1V6zm0-2H3v1h1V4zm0-2H3v1h1V2zm8-1v12c0 .55-.45 1-1 1H6v2l-1.5-1.5L3 16v-2H1c-.55 0-1-.45-1-1V1c0-.55.45-1 1-1h10c.55 0 1 .45 1 1zm-1 10H1v2h2v-1h3v1h5v-2zm0-10H2v9h9V1z"></path></svg></div>
<img class="avatar mr-2 flex-shrink-0 js-jump-to-suggestion-avatar d-none" alt="" src="" width="28" height="28">
<div class="jump-to-suggestion-name js-jump-to-suggestion-name flex-auto overflow-hidden no-wrap css-truncate css-truncate-target">StylishThemes/<mark>GitHub</mark>-Dark</div>
<div class="border rounded-1 flex-shrink-0 bg-gray px-1 text-gray-light ml-1 f6 d-none d-on-nav-focus js-jump-to-badge-search">
In this repository
<span class="d-inline-block ml-1 v-align-middle">?</span>
</div>
<div class="border rounded-1 flex-shrink-0 bg-gray px-1 text-gray-light ml-1 f6 d-on-nav-focus js-jump-to-badge-jump">
Jump to
<span class="d-inline-block ml-1 v-align-middle">?</span>
</div>
</a>
</li>
</ul>Edit test |
|
Just noticed that myself. tbh I like this new search box, what I dont like is how the actual https://github.com/ page looks now, it use to have a nice separation between repos you own and what repos you contribute to, now its wth. |
|
Hi @xt0rted! Thanks for reporting this, it'll be fixed momentarily. |
|
I came up with these li.d-flex a {
background: #181818 !important;
}
li.d-flex a:hover {
background: blue !important;
}
.navigation-focus a:hover {
color: white !important;
}Its interesting to see how that works too ;) |
|
This new addition does interfere with the GitHub Awesome autocomplete extension... but it looks like they're on it. |
|
\o/ |
|
@the-j0k3r Those selectors are much too general. The |
|
Ah I thought it was too good to be true :) |
|
I have just noticed how hovering over the list knocks the icons sideways when title is a bit longer, looks like ass, but good news its a GitHub issue, not a GitHub Dark issue. |
Move ahead, we'll catch up later :) |
|
@Mottie this is also broken again reopen pls. |
GitHub's in the process of rolling out a new search box in the main nav. It mostly looks ok but needs some tweaking for selection/hover.
The text was updated successfully, but these errors were encountered: