Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: New Enviroment Variable for Unix Socket #1497

Open
1 task done
pineapples5972 opened this issue Jun 23, 2024 · 1 comment
Open
1 task done

[Feature Request]: New Enviroment Variable for Unix Socket #1497

pineapples5972 opened this issue Jun 23, 2024 · 1 comment
Assignees

Comments

@pineapples5972
Copy link

Feature Description

Some servers has unix sockets dedicated to host their services.
For example exposing /srv/http/ directory for users to deploy their services at here unix socket can be added to create https://spdf.myserver.xyz

So in current sitution we use socat to create unix socket at that location which listening for particular port i.e 8080 .
/usr/bin/socat UNIX-LISTEN:/srv/http/spdf,mode=660,fork TCP:localhost:8080

And need systemd service file to run this constantly in bg

So this need can be eliminated with Enviromental variable for Systemd service file.

Why is this feature valuable?

For hosting without docker sometimes you need to add two service file

There shouldnt be need to run two systemd service files one for stirling pdf and second for unix socket
There are applications which uses Envirment variable to be added into systemd Service file itself which saves this need.

Environment="SPDF_UNIX_SOCKET=/srv/http/spdf"

Suggested Implementation

Some program like calibre-web provide such env variable eg.
Environment="CALIBRE_UNIX_SOCKET=/srv/http/calibre"

We can add similar env var for systemd service file
Environment="SPDF_UNIX_SOCKET=/srv/http/spdf"

Additional Information

No response

No Duplicate of the Feature

  • I have verified that there are no existing features requests similar to my request.
@Frooodle
Copy link
Member

I will add this but will ask for you to test as I will be unable to!

@Frooodle Frooodle self-assigned this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants